Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: write build number to summary - no ticket #2232

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Dec 2, 2024

Issue

This PR adds some code to the Fastfile which prints the build number of the build to the step summary:
Screenshot 2024-12-02 at 10 19 33


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian force-pushed the feat/add-build-number-to-github-step-summary- branch from d733a5e to feb2a9d Compare December 2, 2024 09:28
Comment on lines +303 to +306
if summary_file.nil? || summary_file.empty?
UI.error("GITHUB_STEP_SUMMARY is not set. Are you running in GitHub Actions?")
return
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it stop fastlane locally? if yes, we should just warn instead

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit feb2a9d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants