-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove folder conversation filter when folder deleted - WPB-13905 #2225
Merged
samwyndham
merged 13 commits into
release/cycle-3.114
from
feat/remove-folder-filter-WPB-13905-v2
Nov 29, 2024
Merged
feat: Remove folder conversation filter when folder deleted - WPB-13905 #2225
samwyndham
merged 13 commits into
release/cycle-3.114
from
feat/remove-folder-filter-WPB-13905-v2
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctoryType.nonDeletedFolders`
We need a method to apply the filter with doing any navigation
echoes-hq
bot
added
the
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
label
Nov 29, 2024
caldrian
approved these changes
Nov 29, 2024
Test Results 4 files 564 suites 8m 37s ⏱️ Results for commit 9651296. ♻️ This comment has been updated with latest results. |
samwyndham
commented
Nov 29, 2024
...onList/ListContent/ConversationListContentController/ConversationListContentController.swift
Show resolved
Hide resolved
samwyndham
commented
Nov 29, 2024
...List/ListContent/ConversationListContentController/ViewModel/ConversationListViewModel.swift
Show resolved
Hide resolved
johnxnguyen
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
netbe
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently when the folder filter is applied and the folder is deleted by removing its final conversation (locally or remotely), the folder filter remains leaving an empty conversation list.
This PR ensures the folder filter is removed when the folder is deleted. Specifically it:
ConversationFilterSelector
that updates the conversation filter based on system events rather than user selection - for now it only handles folder deletions but could handle the events if needed.ConversationDirectoryType.allFolders
withConversationDirectoryType.nonDeletedFolders
- the users of ConversationDirectoryType only care about folders that are not marked for deletion.Old
Simulator.Screen.Recording.-.Test.Device.-.2024-11-29.at.12.23.46.mp4
New
Simulator.Screen.Recording.-.Test.Device.-.2024-11-29.at.12.19.35.mp4
Testing
Please test on iPhone & iPad
Locally
+
icon5
Remotely
Checklist
[WPB-XXX]
.