Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: QRCode reader for deep links - WPB-14547 #2187

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Nov 22, 2024

TaskWPB-14547 [iOS] Add QRCode reader for deep links to the Developer tools

Issue

This was implemented during the platform day.
QR code scanner for deep links in developer tools.

Testing

Open Developer Tools -> Deep links -> Scan the QR code


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Test Results

    2 files    288 suites   2m 37s ⏱️
1 785 tests 1 785 ✅ 0 💤 0 ❌
1 793 runs  1 793 ✅ 0 💤 0 ❌

Results for commit bafd007.

♻️ This comment has been updated with latest results.

@KaterinaWire KaterinaWire changed the title feat: QRCode reader for deep links feat: QRCode reader for deep links - no ticket Nov 22, 2024
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found there's one runtime warning to fix, and @KaterinaWire could you add a ticket to it please?

previewLayer.videoGravity = .resizeAspectFill
view.layer.addSublayer(previewLayer)

captureSession.startRunning()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-[AVCaptureSession startRunning] should be called from background thread. Calling it on the main thread can lead to UI unresponsiveness

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added:

DispatchQueue.global(qos: .userInitiated).async {
            self.captureSession.startRunning()
        }

@KaterinaWire KaterinaWire changed the title feat: QRCode reader for deep links - no ticket feat: QRCode reader for deep links - WPB-14547 Nov 26, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 26, 2024
@KaterinaWire
Copy link
Contributor Author

I found there's one runtime warning to fix, and @KaterinaWire could you add a ticket to it please?

@netbe Created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants