-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: QRCode reader for deep links - WPB-14547 #2187
base: develop
Are you sure you want to change the base?
Conversation
Test Results 2 files 288 suites 2m 37s ⏱️ Results for commit bafd007. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found there's one runtime warning to fix, and @KaterinaWire could you add a ticket to it please?
previewLayer.videoGravity = .resizeAspectFill | ||
view.layer.addSublayer(previewLayer) | ||
|
||
captureSession.startRunning() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-[AVCaptureSession startRunning] should be called from background thread. Calling it on the main thread can lead to UI unresponsiveness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added:
DispatchQueue.global(qos: .userInitiated).async {
self.captureSession.startRunning()
}
@netbe Created |
Issue
This was implemented during the platform day.
QR code scanner for deep links in developer tools.
Testing
Open Developer Tools -> Deep links -> Scan the QR code
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: