Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: process conversation rename event - WPB-10177 #2175

Merged
merged 15 commits into from
Nov 26, 2024

Conversation

jullianm
Copy link
Contributor

@jullianm jullianm commented Nov 20, 2024

WPB-10177

Key points

This PR is part of the quick sync refactoring plan and is related to processing the multiple events we receive from the backend or the push channel.

Specifically, this PR is about porting the existing implementation of the ConversationRename event.

In addition:

  • Redundant message creation code was removed from the ConversationRepository now that we have a dedicated MessageRepository
  • Implementation had to be consequently a bit revisited so we can make use of the MessageRepository where we need to.
  • No longer necessary code was removed

Testing

  • Testing dedicated conversation repository method is correctly invoked by the processor
  • Testing conversation name is correctly updated
  • Add use cases tests for message creation
  • Fix existing tests

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestions

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

Test Results

    5 files    605 suites   9m 17s ⏱️
4 505 tests 4 505 ✅ 0 💤 0 ❌
4 513 runs  4 513 ✅ 0 💤 0 ❌

Results for commit f225967.

@jullianm jullianm added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 163ce55 Nov 26, 2024
12 checks passed
@jullianm jullianm deleted the refactor/process-conversation-rename-event branch November 26, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/technical-debt Changes intended at mitigating risks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants