-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: process conversation rename event - WPB-10177 #2175
refactor: process conversation rename event - WPB-10177 #2175
Conversation
… up redundant messages code - WPB-10177
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor suggestions
WireDomain/Sources/WireDomain/Repositories/Conversations/ConversationRepository.swift
Outdated
Show resolved
Hide resolved
WireDomain/Sources/WireDomain/Repositories/Conversations/ConversationRepository.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
WireDomain/Sources/WireDomain/Repositories/Conversations/ConversationLocalStore.swift
Show resolved
Hide resolved
WireDomain/Sources/WireDomain/Repositories/Conversations/ConversationRepository.swift
Show resolved
Hide resolved
WireDomain/Sources/WireDomain/Repositories/Message/MessageLocalStore.swift
Outdated
Show resolved
Hide resolved
Test Results 5 files 605 suites 9m 17s ⏱️ Results for commit f225967. |
WPB-10177
Key points
This PR is part of the quick sync refactoring plan and is related to processing the multiple events we receive from the backend or the push channel.
Specifically, this PR is about porting the existing implementation of the
ConversationRename
event.In addition:
ConversationRepository
now that we have a dedicatedMessageRepository
MessageRepository
where we need to.Testing
Checklist
[WPB-XXX]
.