-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove architecture related configuration - WPB-12030 #2170
Open
caldrian
wants to merge
48
commits into
develop
Choose a base branch
from
chore/remove-architecture-configs-WPB-12030
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t6-in-wirefoundation
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
Changes intended at mitigating risks
label
Nov 19, 2024
…/swift6-in-wirefoundation
…9-15db04a14dae2bef211276a100877f3f35a64d0b' into fix/migrate-from-file-to-filepath-WPB-14392
…/swift6-in-wirefoundation
Test Results 16 files 1 018 suites 13m 11s ⏱️ Results for commit 1af3f60. ♻️ This comment has been updated with latest results. |
…are-converting-wire-system-to-package-WPB-7306
…6-60385ac019fdeb91f076b7ca474d6d58e5fbbfa8' into chore/swift6-in-wirefoundation
…erting-wire-system-to-package-WPB-7306
…ve-architecture-configs-WPB-12030
…1-a4c915aaee94d5ff042e13671707bc2db7d4484c' into chore/remove-architecture-configs-WPB-12030
…are-converting-wire-system-to-package-WPB-7306
…6' into chore/remove-architecture-configs-WPB-12030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There are some left-over configs from the area when Apple Silicon was introduced and arm64 builds were suddenly needed for simulator.
This PR removes them.
Also the project configuration is cleaned up.
SDKROOT
andONLY_ACTIVE_ARCH
are set in the project and not in each target, like in a new Xcode project.Moreover some empty sections have been removed from the Build Phases configuration.
Related build-assets PR:
https://github.com/wireapp/wire-ios-build-assets/pull/132
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: