Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove architecture related configuration - WPB-12030 #2170

Open
wants to merge 48 commits into
base: develop
Choose a base branch
from

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Nov 19, 2024

TaskWPB-12030 [iOS] Clean up architecture related configs

Issue

There are some left-over configs from the area when Apple Silicon was introduced and arm64 builds were suddenly needed for simulator.
This PR removes them.
Also the project configuration is cleaned up. SDKROOT and ONLY_ACTIVE_ARCH are set in the project and not in each target, like in a new Xcode project.
Moreover some empty sections have been removed from the Build Phases configuration.

Related build-assets PR:
https://github.com/wireapp/wire-ios-build-assets/pull/132


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian added the WIP label Nov 19, 2024
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt Changes intended at mitigating risks label Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Test Results

   16 files  1 018 suites   13m 11s ⏱️
8 312 tests 8 312 ✅ 0 💤 0 ❌
8 331 runs  8 331 ✅ 0 💤 0 ❌

Results for commit 1af3f60.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/technical-debt Changes intended at mitigating risks WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant