chore: Migrate to Xcode 16 - WPB-10898
#2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: technical-roadmap
Test Results1 265 tests 1 265 ✅ 2m 11s ⏱️ Results for commit 1a424db. ♻️ This comment has been updated with latest results. |
samwyndham
force-pushed
the
chore/WPB-10898-xcode-16
branch
from
72ad904 to
8a5c115
Compare
samwyndham
commented
Oct 21, 2024
samwyndham
commented
Oct 21, 2024
samwyndham
commented
Oct 21, 2024
wire-ios-request-strategy/Sources/Message Sending/ProteusMessagePayloadBuilder.swift
Show resolved
Hide resolved
samwyndham
commented
Oct 21, 2024
wire-ios-request-strategy/Sources/Message Sending/ProteusMessagePayloadBuilderTests.swift
Outdated
Show resolved
Hide resolved
samwyndham
requested review from
a team,
netbe,
agisilaos and
jullianm
and removed request for
a team and
netbe
agisilaos
approved these changes
Oct 21, 2024
jullianm
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR migrates to
Xcode 16. I originally attempted to also migrate simulator to iOS 18 but I ran into issues with snapshot tests related to pointfreeco/swift-snapshot-testing#790 so I will break updating the iOS version into a new ticket.Testing
Run the automated tests. I've run the complete test suite here to confirm things are passing: https://github.com/wireapp/wire-ios/actions/runs/11434906873/job/31815070651
Checklist
[WPB-XXX].