fix env variable

wireapp · Nov 29, 2024 · ed100ec · ed100ec
1 parent 563257d
commit ed100ec
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/.github/workflows/_reusable_run_tests.yml b/.github/workflows/_reusable_run_tests.yml
@@ -10,6 +10,10 @@ on:
       branch:
         type: string
         required: true
+      notify_secret:
+        type: string
+        required: true
+
     secrets:
       ZENKINS_USERNAME:
         required: true
@@ -30,6 +34,7 @@ jobs:
     env:
       GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       GITHUB_USERNAME: ${{ secrets.ZENKINS_USERNAME }}
+      SLACK_WEBHOOK_URL: ${{ secrets[inputs.notify_secret] }}
 
     steps:
       - uses: actions/checkout@v4

diff --git a/.github/workflows/test_develop.yml b/.github/workflows/test_develop.yml
@@ -19,6 +19,5 @@ jobs:
     with:
       all: true
       branch: ${{ matrix.branch }}
+      notify_secret: WIRE_IOS_NIGHTLY_WEBHOOK
     secrets: inherit
-    env:
-      SLACK_WEBHOOK_URL: ${{ secrets.WIRE_IOS_NIGHTLY_WEBHOOK }}
diff --git a/.github/workflows/test_pr_changes.yml b/.github/workflows/test_pr_changes.yml
@@ -93,6 +93,5 @@ jobs:
     with:
       folders: ${{ join(fromJson(needs.detect-changes.outputs.folders), ',') }}
       branch: ${{ github.head_ref }}
-    secrets: inherit
-    env:
-      SLACK_WEBHOOK_URL: ${{ secrets.WIRE_IOS_CI_WEBHOOK }}
+      notify_secret: WIRE_IOS_CI_WEBHOOK
+    secrets: inherit