Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add call to action button to allow personal users to be able to create a team (WPB-11326) #3497

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Oct 10, 2024

StoryWPB-11326 [Android] Create Call-To-Action within the app for personal users to be able to start a team


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

In this PR I added:

  • An indicator in user avatar(home screen) that will be displayed for personal users, to get attention of the user to open profile screen. This indicator will be hidden once the user opens profile screen.
  • A new info banner in profile screen that will give personal user the ability to create a team
Screenshot 2024-10-10 at 16 17 29 Screenshot 2024-10-10 at 16 11 29

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…ion-within-the-app-for-personal-users-to-be-able-to-start-a-team

# Conflicts:
#	kalium
@ohassine
Copy link
Member Author

⚠️To be merged after 4.9 code freeze

…-app-for-personal-users-to-be-able-to-start-a-team' into Create-Call-To-Action-within-the-app-for-personal-users-to-be-able-to-start-a-team
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 44.81%. Comparing base (ffd5445) to head (a81c2ac).

Files with missing lines Patch % Lines
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt 40.00% 4 Missing and 2 partials ⚠️
...kotlin/com/wire/android/datastore/UserDataStore.kt 25.00% 3 Missing ⚠️
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3497      +/-   ##
===========================================
- Coverage    44.81%   44.81%   -0.01%     
===========================================
  Files          466      466              
  Lines        15766    15784      +18     
  Branches      2654     2657       +3     
===========================================
+ Hits          7066     7073       +7     
- Misses        7939     7947       +8     
- Partials       761      764       +3     
Files with missing lines Coverage Δ
...alling/ongoing/participantsview/ParticipantTile.kt 0.00% <ø> (ø)
.../main/kotlin/com/wire/android/ui/home/HomeState.kt 28.57% <100.00%> (+5.49%) ⬆️
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 52.11% <50.00%> (-0.41%) ⬇️
...kotlin/com/wire/android/datastore/UserDataStore.kt 30.76% <25.00%> (-0.66%) ⬇️
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt 58.49% <40.00%> (-4.31%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd5445...a81c2ac. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3497.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3497.apk is available for download

Copy link

sonarcloud bot commented Oct 11, 2024

Copy link
Contributor

Built wire-android-staging-compat-pr-3497.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3497.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants