fix: status bar colour during theme change #WPB-11158 #3494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
If status bar had set color the color was overwritten by the night mode change. Now
Causes (Optional)
The night mode change was firing after status bar color change, overwriting the color.
Solutions
Now
CommonTopAppBar
listens to the theme changes so it can reapply the color. I tried do it on a higher level without adding this dependency but did not managed.I also plan to replaceEdit: not feasible at this timerememberSystemUiController
withActivity.enableEdgeToEdge
that was added to the androidx.activity in a separate PRHow to Test
Start a call to your device. Status bar should be coloured to green
Go to settings - appearance while call is in progress
Start changing the theme
Status bar still should be coloured after change
Attachments (Optional)
Before
before.mp4
After
after.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.