-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Audio message slider style #WPB-11384 #3491
base: develop
Are you sure you want to change the base?
Conversation
Built wire-android-staging-compat-pr-3491.apk is available for download |
Built wire-android-dev-debug-pr-3491.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking fantastic 🚀 ! Added some comments about the usage of dimensions()
from our designs' system utility class
...n/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/audio/AudioMessageType.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/audio/AudioMessageType.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/audio/AudioMessageType.kt
Outdated
Show resolved
Hide resolved
Thanks! Habit of using raw values from last project sorry ! |
Built wire-android-staging-compat-pr-3491.apk is available for download |
Built wire-android-dev-debug-pr-3491.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
...n/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/audio/AudioMessageType.kt
Outdated
Show resolved
Hide resolved
Built wire-android-staging-compat-pr-3491.apk is available for download |
Built wire-android-dev-debug-pr-3491.apk is available for download |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3491 +/- ##
===========================================
+ Coverage 44.43% 44.82% +0.39%
===========================================
Files 466 467 +1
Lines 15744 15773 +29
Branches 2653 2654 +1
===========================================
+ Hits 6996 7071 +75
+ Misses 7991 7944 -47
- Partials 757 758 +1
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
What's new in this PR?
Issues
Material3 version 1.3.0 has made some significant changes to the Slider.
Solutions
We needed to adjust new parameters of Slider Thumb and Track in order to meet old view appearance.
Testing
How to Test
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.