Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Audio message slider style #WPB-11384 #3491

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Oct 9, 2024

BugWPB-11384 [Android] Audio message sliders don't match design after library update

What's new in this PR?

Issues

Material3 version 1.3.0 has made some significant changes to the Slider.

Solutions

We needed to adjust new parameters of Slider Thumb and Track in order to meet old view appearance.

Testing

How to Test

  • Record voice message
  • Confirm that thumb is in right color and shape (circle)
  • Track is slim and does not have any weird shapes on it
  • When sliding the thumb by hand the thumb and track does not change size

Attachments (Optional)

Before After
Screenshot_20241009_135618_Wire Beta Screenshot_20241009_135352_Wire Beta

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2024

CLA assistant check
All committers have signed the CLA.

@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Built wire-android-staging-compat-pr-3491.apk is available for download

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Built wire-android-dev-debug-pr-3491.apk is available for download

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fantastic 🚀 ! Added some comments about the usage of dimensions() from our designs' system utility class

@m-zagorski
Copy link
Contributor Author

Looking fantastic 🚀 ! Added some comments about the usage of dimensions() from our designs' system utility class

Thanks! Habit of using raw values from last project sorry !

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Built wire-android-staging-compat-pr-3491.apk is available for download

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Built wire-android-dev-debug-pr-3491.apk is available for download

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

Built wire-android-staging-compat-pr-3491.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3491.apk is available for download

Copy link

sonarcloud bot commented Oct 14, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.82%. Comparing base (0725cf5) to head (5b02187).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3491      +/-   ##
===========================================
+ Coverage    44.43%   44.82%   +0.39%     
===========================================
  Files          466      467       +1     
  Lines        15744    15773      +29     
  Branches      2653     2654       +1     
===========================================
+ Hits          6996     7071      +75     
+ Misses        7991     7944      -47     
- Partials       757      758       +1     
Files with missing lines Coverage Δ
...tions/model/messagetypes/audio/AudioMessageType.kt 0.00% <ø> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0725cf5...5b02187. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bugs Technical or functional defects in the product size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants