fix: crash on removing images on preview screen [WPB-11147] #3457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
The app crashes when user tries to remove not currently selected image on preview screen.
Causes (Optional)
HorizontalPager
usesSubcomposeLayout
, so after changing the state and removing some items, it still uses old state containing removed element when running the subcomposition to compose pages.Solutions
Provide a key which uniquely identifies each page, so if you add/remove items before the current visible item the item with the given key will be kept as the first visible one.
Testing
How to Test
STR:
-open conversation
-tap on attachments > gallery
-select 3 images
-on preview screen, tap on the second image (to see it in full view)
-delete the first image
-app should not crash and the image should be removed
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.