-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement binding specific errors [WPB-14352] #771
Commits on Nov 22, 2024
-
feat: proteus error codes are
Option<u16>
notu32
Returning an error code whose zero value indicates success is a reasonable pattern, in C. We are not programming in C. Eventually we're going to get rid of this pattern entirely. For now, we can at least use a real `Option` type to indicate whether an error in fact exists. Also, the Proteus implementation specifies that the error code is a `u16`. No idea why that got widened to a `u32`, but that was pointless, so it's back to a `u16` here.
Configuration menu - View commit details
-
Copy full SHA for d2e9307 - Browse repository at this point
Copy the full SHA d2e9307View commit details
Commits on Nov 25, 2024
-
feat: refactor WASM error types
Clients only care about a limited set of errors, which we enumerated in the root issue. This commit refactors the client-visible errors (in WASM) to focus only on the set they care about.
Configuration menu - View commit details
-
Copy full SHA for b13d88f - Browse repository at this point
Copy the full SHA b13d88fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17ce552 - Browse repository at this point
Copy the full SHA 17ce552View commit details -
feat: refactor non-WASM error types
Clients only care about a limited set of errors, which we enumerated in the root issue. This commit refactors the client-visible errors (other than WASM) to focus only on the set they care about.
Configuration menu - View commit details
-
Copy full SHA for 40b4576 - Browse repository at this point
Copy the full SHA 40b4576View commit details -
test(wasm): fixup tests broken by recent changes
Turns out there is a whole human-written section in the TS bindings which parses the output of our error types and turns it into a somewhat better error object. That needed to be updated to handle the new, simpler output serialization.
Configuration menu - View commit details
-
Copy full SHA for bb9ea00 - Browse repository at this point
Copy the full SHA bb9ea00View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5f2880 - Browse repository at this point
Copy the full SHA d5f2880View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b752ee - Browse repository at this point
Copy the full SHA 6b752eeView commit details -
chore(uniffi/jvm): get kotlin to build _at all_
Kotlin tests are still failing due to previous changes, but at least the fundamental build operation is now succeeding. It's a start! Ran a Kotlin code formatter, intending only to hit the auto-generated files; turns out there were a bunch of human-maintained files in the tree also. Unfortunately, at that point, there were quite a lot of uncommitted changes. Didn't want to go through the effort of going back and unformatting the unrelated stuff, so that's all in here also.
Configuration menu - View commit details
-
Copy full SHA for 61c4f2f - Browse repository at this point
Copy the full SHA 61c4f2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c34db6 - Browse repository at this point
Copy the full SHA 8c34db6View commit details