Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postresql fix #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Postresql fix #7

wants to merge 2 commits into from

Conversation

dzaporozhets
Copy link

For postgres 8.4 sql like this "CREATE TABLE archived_articles LIKE articles" is invalid.
This is correct one "CREATE TABLE archived_articles (LIKE articles)"

Fixes #5

Dmitriy Zaporozhets added 2 commits April 5, 2011 14:21
@nirvdrum
Copy link

nirvdrum commented Jun 7, 2011

I just got burned by this, too. I can verify the fix works.

@nirvdrum
Copy link

nirvdrum commented Jun 7, 2011

I take that back. The second commit, including indexes is bad if the index is named because then you get a duplicate index error. I believe it works fine if the index is only structured and postgres is free to add its own name.

@nirvdrum
Copy link

nirvdrum commented Jun 7, 2011

Sorry, I'm gradually becoming more familiar with the codebase here. It'd be better if the "INCLUDING INDEXES" stuff was contingent on the config[:indexes] value. But I think the lib goes ahead and adds those indices anyway, so the clause may not be necessary.

@matthewrudy
Copy link

I have the same problem
but fixed it with this fork https://github.com/mogotest/also_migrate.git

cant rate it versus yours Randx,
but this one worked for me.

But whatever gets released will make me happy.

@blakewatters
Copy link
Contributor

Bump. This is a good fix that should be merged

@pmanrubia
Copy link

Please, I'd appreciate if you merge this fix.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres 8.4 error on rake db:migrate
5 participants