-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create partials for the relation controller form footers #954
Conversation
@mjauvin it would be better to replace the contents of the footer with a call to make a relation partial as that would allow for overriding the footer contents in the same way as the other behaviors, placing a properly named partial in your controller folder. |
Perhaps, but would it also allow to replace this dynamically when extending a third party plugin controller? |
@mjauvin sure, because plugins can extend controller's viewPaths arrays. Same way the Tailwind UI plugin works. |
This is ready to review. |
@mjauvin can the partials include their containing divs as well? Also can you make a PR to the docs to accompany this? |
Why ? |
I don't have a good enough reason so fair enough 😜 Can we rename it to |
Done! |
Just need a docs PR to mention the new partials now |
In here ? We don't document any of the partials specifically, why these ? |
@mjauvin TBH I just didn't check what we had documented already or not, the current docs are fine for this change. Thanks! 😂 |
We can now override the different Relation Controller form footers (buttons).