Override Symfony Process.

[mjauvin]

This is required in order to handle an exception when open_basedir restrictions are in effect, preventing a process to be created with TTY mode enabled.

[LukeTowers]

Symfony looks like it already does this? symfony/symfony@a1398f6

[mjauvin]

Symfony looks like it already does this? symfony/symfony@a1398f6

This code:

    public function setTty(bool $tty): static
    {
        if ('\\' === \DIRECTORY_SEPARATOR && $tty) {
            throw new RuntimeException('TTY mode is not supported on Windows platform.');
        }

        if ($tty && !self::isTtySupported()) {
            throw new RuntimeException('TTY mode requires /dev/tty to be read/writable.');
        }

        $this->tty = $tty;

        return $this;
    }

Is not the same at all, if you look carefully.

[LukeTowers]

@mjauvin what's the difference? It looks like isTtySupported() also checks the readable / writable status of /dev/tty

[mjauvin]

@mjauvin what's the difference? It looks like isTtySupported() also checks the readable / writable status of /dev/tty

It does, but it looks like PHP's open_basedire restrictions don't apply for this check, but they do for is_readable()

[LukeTowers]

Interesting. Can we override isTtySupported() instead and also submit an issue to Symfony to report the problem?

[mjauvin]

Interesting. Can we override isTtySupported() instead and also submit an issue to Symfony to report the problem?

I tried with this overriden method but it doesn't get called somehow:

    public static function isTtySupported(): bool
    {   
        static $isTtySupported;

        if ('/' === \DIRECTORY_SEPARATOR) {
            try {
                $readable = is_readable('/dev/tty');
            } catch (\Exception $e) {
                throw new RuntimeException($e->getMessage());
            }
        }

        return $isTtySupported ??= ('/' === \DIRECTORY_SEPARATOR && stream_isatty(\STDOUT));
    }

[mjauvin]

Only if I replicate Symfony's setTty() method in my overriden class, then my isTtySupported method gets called.

Maybe because this is a static method ?

[mjauvin]

@LukeTowers The problem is Symfony's setTty() method uses "self::isTtySupported()instead ofstatic::isTtySupported()` which prevents my overriden class method to be called.

[mjauvin]

Symfony merged the PR, so we won't be needing this.