We shouldn't test completely third-party code.

We no longer extend this class, and it doesn't seem to provide any functionality anyway.

This method is strictly a relationship method and should be grouped with the other relationship methods.

In order to maintain some semblance of parity with Laravel, we'll now use Laravel's relation constructors and simply overwrite the "new" relation methods to create Winter's relation instances.

Winter's relation name and defined constraints functionality will now be called in our own handler after the relation has been instantiated. This will allow us to review the relation directly before any Winter code runs.

This allows people using the relation method format to define the "delete" attribute available to relation definition arrays.

…methods

The "validateRelationArgs" method does a whole lot of nothing - the most it does is enforce required parameters. These can be picked up in Laravel anyway.

Added the ability to define the field name and use this as a constraint for attachment relations, separating it from the relation name.

The "Test" suffix might inadvertently be picked up by PHPUnit as a test case.

…relations

Also add ability to define relations as "counted" relations only.

When using the Laravel style relation method and countOnly flag, it was not applying the constraint automatically.

Co-authored-by: Luke Towers <[email protected]>

Co-authored-by: Luke Towers <[email protected]>

Co-authored-by: Luke Towers <[email protected]>

Co-authored-by: Luke Towers <[email protected]>

Co-authored-by: Luke Towers <[email protected]>

Co-authored-by: Luke Towers <[email protected]>

Co-authored-by: Luke Towers <[email protected]>

Co-authored-by: Luke Towers <[email protected]>

Co-authored-by: Luke Towers <[email protected]>

Co-authored-by: Luke Towers <[email protected]>

Co-authored-by: Luke Towers <[email protected]>

…rties

Instead of extending the Relation class, we will make the soft delete methods available immediately to the relations.

However, you can only *enable* soft delete if the related model uses the soft delete trait, thereby ensuring the correct soft delete functionality is available to the model when required.

…rove performance

To prevent a particular infinite loop, we need to define the Relation type when using the Relation attribute for a method so that we don't have to instantiate the relation in order to find out what type it is.

When a relation is defined in both the relation properties and as a method with the same name, an exception will be thrown.