add more comments and cleanup

wintercms · Oct 15, 2023 · bed6650 · bed6650
1 parent fa4a2dc
commit bed6650
Showing 1 changed file with 16 additions and 6 deletions.
diff --git a/tests/Database/ModelTest.php b/tests/Database/ModelTest.php
@@ -148,6 +148,7 @@ public function testDeleteWithThroughRelations()
 
         $website->delete();
 
+        // verify nothing has been deleted
         $this->assertEquals($phoneRelationCount, $user->phone()->count());
         $this->assertEquals($postsRelationCount, $user->posts()->count());
 
@@ -161,14 +162,15 @@ public function testDeleteWithHasManyRelation()
         $website = $this->seeded['websites'][0];
         $user = $this->seeded['users'][0];
 
-        $usersRelationCount = $website->users()->count();
         $websiteCount = Website::count();
         $userCount = User::count();
 
         $website->delete();
 
-        $this->assertEquals($usersRelationCount, $website->users()->count());
+        // verify website has been deleted
         $this->assertEquals($websiteCount - 1, Website::count());
+
+        // verify user still exists
         $this->assertEquals($userCount, User::count());
 
         // test with relation "delete" flag set to true
@@ -183,7 +185,10 @@ public function testDeleteWithHasManyRelation()
 
         $website->delete();
 
+        // verify website has been deleted
         $this->assertEquals($websiteCount - 1, Website::count());
+
+        // verify user has been deleted
         $this->assertEquals($userCount - 1, User::count());
     }
 
@@ -192,13 +197,15 @@ public function testDeleteWithMorphManyRelation()
     {
         $post = $this->seeded['posts'][0];
 
-        $commentsRelationCount = $post->comments()->count();
         $postCount =  Post::count();
         $commentCount = Comment::count();
 
         $post->delete();
 
+        // verify post has been deleted
         $this->assertEquals($postCount - 1, Post::count());
+
+        // verify comment still exists
         $this->assertEquals($commentCount, Comment::count());
 
         // test with relation "delete" flag set to true
@@ -213,7 +220,10 @@ public function testDeleteWithMorphManyRelation()
 
         $post->delete();
 
+        // verify post has been deleted
         $this->assertEquals($postCount - 1, Post::count());
+
+        // verify comment has been deleted
         $this->assertEquals($commentCount - 1, Comment::count());
     }
 
@@ -228,12 +238,12 @@ public function testDeleteWithBelongsToManyRelation()
 
         $user->delete();
 
-        // verify that pivot record has been removed
-        $this->assertEquals($userRolePivotCount - 1, DB::table('role_user')->count());
-
         // verify user has been deleted
         $this->assertEquals($userCount - 1, User::count());
 
+        // verify that pivot record has been removed
+        $this->assertEquals($userRolePivotCount - 1, DB::table('role_user')->count());
+
         // verify both roles still exist
         $this->assertEquals($roleCount, Role::count());