-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Lua with LuaJIT and restrict loaded libraries for auto splitters #34
Conversation
Tony Hawk's Underground seemed to not work. It first made me switch out some logic (I had to change the '&' to 'and' on line 18). The timer started correctly (loading works too) but LAST didn't split (which is weird considering it printed out the debug message for splitting)
|
Do you get the same issue with JSR? I quickly tested JSR and it was working as expected. |
|
The bit library is now available for auto splitters. |
Just to have it in hand Confirmed to work:
|
I think mec.lua and mecadntp.lua should work exactly the same as before since the only breaking change found in the auto splitters was the change in bitwise operations. I'm happy to merge this if either of you approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just 1 small rename but other than that i see all is good, the change is fast
Mirror's Edge Catalyst's auto splitter doesn't work. LAST complains about most of the readAddress variables returning the wrong return type (expected boolean). Some logic seems to be working. It does print the debug message for loading, but nothing else works. Also for Tony Hawk's Underground, it only started working after I switched from Wine Staging (8.21) to Proton Hotfix inside Lutris. |
Does #43 fix them? Edit: Never mind, it doesn't |
Restrict the loaded libraries to only base, string, math and jit. This is based on information from:
http://lua-users.org/wiki/SandBoxes
TODO: