Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source generator v2 #22

Merged
merged 5 commits into from
Jun 8, 2024
Merged

Source generator v2 #22

merged 5 commits into from
Jun 8, 2024

Conversation

pjmagee
Copy link
Contributor

@pjmagee pjmagee commented Jun 7, 2024 •
edited
Loading

#10

@wingyplus
Copy link
Owner

LGTM. 👍

Could you rebase this branch? Just push a fix on code render to main and want to make sure every work perfectly. :)

@pjmagee
Merge branch 'main' of github.com:wingyplus/dagger-dotnet-sdk
97902fd
@pjmagee
- Incremental generator
79292f5 
- Added some extra basic checks on generator Diagnostic
- Small format change in code gen
@pjmagee
Copy link
Contributor Author

pjmagee commented Jun 8, 2024

LGTM. 👍

Could you rebase this branch? Just push a fix on code render to main and want to make sure every work perfectly. :)

Done. ran test and everything pass

@wingyplus
Copy link
Owner

Thank you for your help. ❤️

@wingyplus wingyplus merged commit 14280fc into wingyplus:main Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wingyplus wingyplus wingyplus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjmagee @wingyplus