-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bring eventbridge
#42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very elegant!
BREAKING CHANGE: the `url()` and `inflightUrl()` methods have been removed in favor of a `url` property.
* chore(bedrock): replacing BEDROCK_DEV with isTestEnvironment * chore(bedrock): replacing BEDROCK_DEV with isTestEnvironment * Update bedrock/README.md * Update bedrock/bedrock.w * Update bedrock/joke.test.w
* wip * Update github/lib.test.w * Update github/lib.test.w * updates * updates * updated README * ignore test due to winglang/wing#5408 * adding description to github/package.json * adding author to github/package.json --------- Co-authored-by: Eyal Keren <[email protected]>
* fix(github): mts to js files * fix(github): mts to js files * fix(github): mts to js files
* fix(github): using interface for credentials instead of cloud.secret * fix(github): can't compile to tf-aws, missing cloud.service * fix(github): can't compile to tf-aws, missing cloud.service
Set up GitHub releases. This will be used to set up a webhook that detects newly released packages from GitHub release events. Version bumped `postgres` for testing purposes
Hi, This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days. |
Pretty much finished - it deploys to AWS as well. However, the test is not properly working for some reason I couldn't figure out. The node hiding doesn't work anymore, due to some changes in the way the map is rendered. But I think it's still pretty good anyway. To find all the quirks and implementation mismatches between sim / tf-aws some real-world dog-fooding would be great! |
Thanks for contributing, @skorfmann! This PR will now be added to the merge queue, or immediately merged if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool stuff!
A few additional thoughts about api
}); | ||
|
||
new cloud.Function(inflight () => { | ||
bus.putEvents([{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have made sense to be variadic (...) so the array is not needed:
bus.putEvents([{ | |
bus.putEvents({ |
|
||
let bus = new eventbridge.Bus(); | ||
|
||
bus.subscribeFunction("github.pull-request.created", inflight (event) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of feels like subscribeFunction
should take a cloud.Function
and this should be called onEvent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense. do we need subscribeFunction
? seems redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required
This adds an EventBridge library.
This implements the simulator version on top of the
cloud.Topic
and adds a subset of the available filters, namely:progress
sim view