chore: use peer dependencies and make packages more similar #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkMcCulloh
commented
Apr 3, 2024
Chriscbr
approved these changes
Apr 3, 2024
|
Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if |
mergify bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
Followup to #179 Also updated dynamodb package.json version since I forgot in the last PR.
eladb
reviewed
Apr 4, 2024
| @@ -17,16 +17,13 @@ | |||
| }, | |||
| "license": "MIT", | |||
| "peerDependencies": { | |||
| "cdktf": "*", | |||
| "winglang": "*" | |||
| "cdktf": "^0.20.6", | |||
There was a problem hiding this comment.
can we add some validation in the PR builds in this repo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this PR is to change all package to use peerDependencies instead of dependencies (see winglang/wing#5470)