Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default value in macro prompt #2475

Merged
merged 6 commits into from
Mar 3, 2024

Conversation

warmans
Copy link
Contributor

@warmans warmans commented Mar 2, 2024

  1. Adds an optional third value to prompts that contains the default value e.g. {prompt|pos|0} would show 0 in the input labeled pos when the panel opens.
  2. Updates help text to describe how to set defaults (also adds note about reusing placeholder values).
  3. Removes some unused imports.

@breiler
Copy link
Collaborator

breiler commented Mar 3, 2024

Clean and simple. Can you just add a couple of <br/> in the the helper text as it gets quite long at the moment:

image

@warmans
Copy link
Contributor Author

warmans commented Mar 3, 2024

Hi, thanks for reviewing. I've tidied up the text a bit and put in some breaks. Let me know if there are any other changes needed.

image

@breiler breiler merged commit f87063f into winder:master Mar 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants