-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add freerdp backend #42
Conversation
So I think generally the the base is finished and ready for merge. Just waiting for some reviews. Maybe we want to change to command names (later this would we much more complicated). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
We could just keep what you've called |
@oskardotglobal did you try and build this branch ? Or should I test it on my side ? |
Nope, I'll test this later |
I tested the build works, but there are a few issues, I noticed @LDprg
|
@AkechiShiro the latter is included in #26 |
@AkechiShiro The first one is that winapps doesnt disable the freerdp output (which contains alot of unnecessary warings). I will investigate into this. |
@AkechiShiro did you test it with the generated quickemu from #26? I am not sure if we need a port forwarding from the guest to host to make rdp communication working per default. |
@LDprg no I removed all the previous files to test cleanly but I understand that there is no quickemu get and VMs files |
@LDprg I'll test it |
So finally I fixed the log outputs of freerdp causing unessecary warnings to be shown. Later we could redirect its output to some log files, however this will be in a sperate PR (just want this get through as fast as possible). Furthermore I fixed some minor issues after the merge of #26 and renamed the app command to run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
@oskardotglobal I removed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This moved from #30 to here for better way of working.