Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up old network profiles #258

Closed
wants to merge 5 commits into from
Closed

Clean up old network profiles #258

wants to merge 5 commits into from

Conversation

itiligent
Copy link
Contributor

As requested by @oskardotglobal. This PR will help keep Windows networking tidy. The install.bat changes will:

  1. Create a new powershell script and save this to c:\windows. The Powershell script will clear unused network profile names that were automatically created at previous system reboots.
  2. Install.bat also creates a new scheduled task that will run the cleanup powershell script at boot
  3. A registry change is further added to RDPapps.reg to disable the "Do you want your PC to be discoverable" nag screen after each reboot
  4. I've also added simple comments to each of the reg file entries for clarity.

itiligent and others added 4 commits September 18, 2024 14:50
@itiligent
Clean up old network profiles
1496041 
Keep Windows networking tidy. At boot a Powershell script will run that  clears out old network profile names automatically created at previous system reboots. A regist change disables the "Do you want your PC to be discoverable" nag screen after eachc reboot
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
90b3422 
for more information, see https://pre-commit.ci
@itiligent
change script path to %windir%
e839d1f
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6d67815 
for more information, see https://pre-commit.ci
@oskardotglobal oskardotglobal linked an issue Sep 18, 2024 that may be closed by this pull request
Every container or host system reboot resets Windows network settings #161
Closed
oskardotglobal
oskardotglobal requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@oskardotglobal oskardotglobal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. However, could you please merge upstream/main into your local branch so that the license checks can add you as a copyright owner to the install.bat?

@itiligent
Copy link
Contributor Author

sorry, my bad. Done now.

@oskardotglobal
Copy link
Member

The CI doesn't seem to be picking up on your changes, can you add yourself to the copyright header of the file manually?

@itiligent
Copy link
Contributor Author

I'm sorry I don't understand what you mean

@itiligent
Copy link
Contributor Author

Having issues with the copyright thingy. I will delete this PR, re-sync my fork and recreate the PR to see if that helps.

@itiligent itiligent closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskardotglobal oskardotglobal oskardotglobal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Every container or host system reboot resets Windows network settings
2 participants
@itiligent @oskardotglobal