Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve licensing issues #240

Merged
merged 6 commits into from
Sep 14, 2024
Merged

Resolve licensing issues #240

merged 6 commits into from
Sep 14, 2024

Conversation

oskardotglobal
Copy link
Member

Moving this here since Github didn't allow properly reverting #15.

@oskardotglobal
Copy link
Member Author

cc @GreatNovaDragon

@oskardotglobal
Copy link
Member Author

So @AkechiShiro suggested this license: https://commission.europa.eu/content/european-union-public-licence_en (full license text).

This license is OSI-approved. However, the FSF classifies it as non-compatible with the GPL because it technically allows sublicensing and relicensing the work under a GPLv3. In our case, this would not be possible due to the CLA, but I don't see the advantages of the EUPL right now.

@AkechiShiro
Copy link

Could we then move from GPLv3 to AGPLv3 ? @oskardotglobal

@oskardotglobal
Copy link
Member Author

@AkechiShiro The only difference between the AGPLv3 and the GPLv3 is the source distribution clause when distributing it over a network. Since WinApps is distributed as it's source, I don't see why this would matter.

@AkechiShiro
Copy link

AkechiShiro commented Sep 7, 2024

Hmm I thought it would be useful if someone tries to make a payed service with winapps without redistributing the source, nor providing the license we use, and wouldn't need to provide their modifications as source code.

https://opensource.stackexchange.com/questions/5041/of-the-differences-between-the-gplv3-and-the-agplv3-texts-what-to-make-of-them#5054

@oskardotglobal
Copy link
Member Author

Well, the changed Section 13 explicitly talks about a server, I don't see how one would make a paid service out of WinApps.

@oskardotglobal
Copy link
Member Author

Ok, this is now ready for review

@AkechiShiro
Copy link

AkechiShiro commented Sep 7, 2024

@oskardotglobal So you don't see how it would be possible to serve Winapps through an xrdp server or KasmVNC ?

Should I poc this real quick?

@oskardotglobal
Copy link
Member Author

Well then you would be providing Windows VMs as a service, not WinApps, would you not?
We can't really stop someone from just selling VMs with RDP enabled and then "recommending" their users to use WinApps. But you're probably right, I can change this to an AGPLv3 if you want.

@AkechiShiro
Copy link

I would like if there is no objection from anyone that we'd use AGPLv3 @GreatNovaDragon

@GreatNovaDragon
Copy link
Contributor

sure, agpl works for me

@oskardotglobal
Copy link
Member Author

Can someone review?

@AkechiShiro
Copy link

@oskardotglobal can you rebase on main I see changes on CI and the setup script, this shouldn't be here.

@oskardotglobal oskardotglobal force-pushed the add-contribution-guidelines branch from 60ef05a to 2d06aa2 Compare September 9, 2024 15:17
@oskardotglobal
Copy link
Member Author

The CI changes are just to ensure the license headers on all files.

.pre-commit-config.yaml Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
apps/access-o365-x86/info Show resolved Hide resolved
apps/access-o365/info Show resolved Hide resolved
@AkechiShiro
Copy link

I've created this matrix channel : https://matrix.to/#/#winapps:matrix.org feel free to join @oskardotglobal @LDprg @GreatNovaDragon

@AkechiShiro
Copy link

What is missing to merge this PR ?

@oskardotglobal
Copy link
Member Author

Nothing that I know of

@AkechiShiro
Copy link

Maybe I'll open an documentation issue for the CI actions used, but I dont think there is anything else of concern

@oskardotglobal oskardotglobal merged commit 41a1450 into main Sep 14, 2024
3 checks passed
oskardotglobal added a commit that referenced this pull request Sep 14, 2024
@AkechiShiro
Copy link

Hey @oskardotglobal and @LDprg could you join the Matrix/Element chat please ?

I would like to discuss about wayland support plans and I'm looking into this : https://github.com/elliotkillick/qvm-create-windows-qube

@oskardotglobal
Copy link
Member Author

Hold on I'll have to unfuck my homeserver's federation first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants