Simplify installation process

[oskardotglobal]

This PR does the following:

• installer.sh is renamed to setup.sh
• The setup.sh and bin/winapps are now symlinked to $BIN_PATH
• It's checked that $BIN_PATH is on $PATH
• The script also now clones the repo to a default location in ~/.local/bin/winapps

[LDprg]

Great, this would simplify alot and prevent a lot of problems related to local git repos.

[KernelGhost]

These are some fantastic and welcomed changes. Unfortunately my computer is out of order currently so I have not been able to test these changes. Based on a cursory inspection, LGTM.

[oskardotglobal]

@LDprg Could you test this on your system?

[LDprg]

@LDprg Could you test this on your system?

I will take a look soon, but I am currently very low on time.

[AkechiShiro]

On which Distro (I'm daily driving NixOS at the moment) would you like me to test this @oskardotglobal (Debian or ArchLinux ?) looking to move forward #234

[oskardotglobal]

I also run Nix and I've tested it there, but if you test it on another distro try Debian

[AkechiShiro]

Ran into this issue after installing deps (curl and dialog) @oskardotglobal

[AkechiShiro]

I think the issue comes from here :

[AkechiShiro]

Removing readonly doesn't seem to fix it :

[oskardotglobal]

@AkechiShiro This should fix your problem

[AkechiShiro]

Seem to have an issue again @oskardotglobal

I don't think you're checking if the current user is in sudoers or wheel group also what if user is using something else than sudo like doas ?

I'm just trying it as a total Linux newbie to make sure we squash easy stuff early on.

Current user + manual => currently testing.

[AkechiShiro]

Didn't follow the steps properly but I think we should create the config file by default instead of asking the user to do another step :

Should I reinstall or uninstall ? The installation state is not clear right now

[AkechiShiro]

I think dependency checks should be done at the beginning, I've had to install 2 deps before starting the script and now it is asking for more :

I can help on reworking the PR to make it better if needed

[AkechiShiro]

This dependency does not exist on Debian :

[oskardotglobal]

These issues are not related to this PR, but need addressing anyways

[AkechiShiro]

Seems freerdp3 is not available on Debian...

I probably need to enable backports from unstable branches : https://packages.debian.org/bookworm-backports/freerdp3-x11

This will need documentation, opened #243

[oskardotglobal]

Either that or use Flatpak, but that's kind of broken
We need a solution for this, ideally we'd be able to ship FreeRDP with winapps

[oskardotglobal]

Or you know, just tell everyone to install the Nix package manager and install WinApps through there

[AkechiShiro]

We both know that's not gonna work out XD, but someday maybe Nix will become mainstream

[AkechiShiro]

We can ship Nix with Winapps and have it pull freerdp3

[AkechiShiro]

We can use @oskardotglobal : https://github.com/matthewbauer/nix-bundle

[oskardotglobal]

We both know that's not gonna work out XD, but someday maybe Nix will become mainstream

We can always dream ;D

Nix-bundle seems like a good idea, we can experiment with that

[oskardotglobal]

Actually, it seems like not that straight forward. It seems we'd need our package to be on nixpkgs or at least inside a nixpkgs fork and our package emits 2 binaries whilst nix-bundle seems to only emit one. This might be fixable if we split installer and winapps itself into two nix packages though

[oskardotglobal]

I think this PR can be merged now though, we can continue this discussion in #234.

[AkechiShiro]

I thought I'd have time to do a retest before the merge, so we can identify potential improvement points and mark them as open issues, that would get resolved in further PRs.

[oskardotglobal]

I did test this extensively, but the bugs you are facing are unrelated to this PR itself; they are general problems with how the installer works.

[AkechiShiro]

Then we should open issue to track them, because I don't know them by heart on my side and I will forget about them after a few weeks