Skip to content

Commit

Permalink
Tab strip offset split into separate flag
Browse files Browse the repository at this point in the history
  • Loading branch information
win32ss committed May 17, 2024
1 parent b84830e commit b4d5e9e
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions chrome/browser/about_flags.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11426,6 +11426,10 @@ const FeatureEntry kFeatureEntries[] = {
"Disable Blockage Of Unnecessarily Bloated Web Elements",
"Disable blockage of unnecessarily bloated web elements, including large images that can force the browser to allocate hundreds of megabytes of memory.",
kOsWin, SINGLE_VALUE_TYPE("disable-webbloat-mitigation")},
{"old-tab-strip-bounds",
"Enable Old Tab Strip Bounds",
"Enable the old tab strip bounds, specifically on the left (or right in an RTL configuration).",
kOsDesktop, SINGLE_VALUE_TYPE("old-tab-strip-bounds")},
// TODO: move all Supermium-specific flags to new source file.

// NOTE: Adding a new flag requires adding a corresponding entry to enum
Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/ui/views/frame/browser_frame_view_win.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ bool BrowserFrameViewWin::CaptionButtonsOnLeadingEdge() const {
gfx::Rect BrowserFrameViewWin::GetBoundsForTabStripRegion(
const gfx::Size& tabstrip_minimum_size) const {
int x = CaptionButtonsOnLeadingEdge() ? CaptionButtonsRegionWidth() : 0;
if (base::CommandLine::ForCurrentProcess()->HasSwitch("classic-omnibox"))
if (base::CommandLine::ForCurrentProcess()->HasSwitch("old-tab-strip-bounds"))
x = 8;
int end_x = width();
if (!CaptionButtonsOnLeadingEdge()) {
Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ gfx::Rect OpaqueBrowserFrameViewLayout::GetBoundsForTabStripRegion(
const gfx::Size& tabstrip_minimum_size,
int total_width) const {
int x = available_space_leading_x_;
if (base::CommandLine::ForCurrentProcess()->HasSwitch("classic-omnibox"))
if (base::CommandLine::ForCurrentProcess()->HasSwitch("old-tab-strip-bounds"))
x = 8;
const int available_width = available_space_trailing_x_ - x;
return gfx::Rect(x, GetTabStripInsetsTop(false), std::max(0, available_width),
Expand Down
2 changes: 1 addition & 1 deletion v8
Submodule v8 updated from ddb475 to 308db8

1 comment on commit b4d5e9e

@Alex313031
Copy link

@Alex313031 Alex313031 commented on b4d5e9e May 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@win32ss What was the V8 update? Upstream?, or were you adding the V8 part of the recent CVE fix? If so, can you let me know what you changed/what was changed.

If you applied an upstream patch, you should also change the revision in DEPS, since it is still at ddb4756a90fb7d89dc789859f8b2a3639d8de125

Update: Was the fix this? > https://chromium.googlesource.com/v8/v8/+/c6b8b43c3042d99f07d5cc0771e58511afaa66a3..1ecf7c4897c3ed68d65ac467cce5da142b495756

Please sign in to comment.