Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old deprecated #1083

Merged
merged 11 commits into from
May 30, 2024

Conversation

philclifford
Copy link
Member

@philclifford philclifford commented May 18, 2024

Packages removed six months (or a year or more) ago ought to be pruned to avoid annoying deb-get users who may have chosen to install them via deb packages (e.g from the ubuntu repos) with ongoing warnings.

Six months should be adequate time for users to act on the deprecation messages. Maybe one month would be better.

It might be possible to automate. My half-cunning process was to identify the candidates from the git blame timestamp of the '^#' lines in manifest then

for app in  <list_to_be_expunged>
do 
  git rm packages/${app} 
  sed -i "/#${app} /d" manifest
  git add manifest
  git commit -m "chore(${app}): remove packages long deprecated"
done

given a way to build find the list it would then be a snip for gh to make a branch, do the above loop and create a PR for review.

Update - CoPilot is quite handy - see #1084 for something that needs polish and refactoring, but might be interesting..

@philclifford
Copy link
Member Author

This might also be an indicator that the deprecation warning code could do with a look: I think it should only warn if the app is deprecated in the manifest AND the app is under our aegis, not merely installed from a deb)

@flexiondotorg flexiondotorg merged commit 48bc2ab into wimpysworld:main May 30, 2024
1 check passed
@philclifford philclifford deleted the remove-old-deprecated branch June 24, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants