Merge pull request #63

Fix a bug in where condition when persisting entity
williarin · Dec 5, 2023 · 81d72db · 81d72db
2 parents 1b8e4c6 + 57fd99c
commit 81d72db
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -22,12 +22,15 @@ jobs:
 
         runs-on: ubuntu-20.04
 
+        continue-on-error: ${{ matrix.experimental }}
+
         strategy:
+            fail-fast: true
             matrix:
-                php: ['8.0', '8.1', '8.2']
+                php: ['8.0', '8.1', '8.2', '8.3']
                 experimental: [false]
                 include:
-                    -   php: '8.3'
+                    -   php: '8.4'
                         experimental: true
 
         steps:

diff --git a/src/Bridge/Repository/AbstractEntityRepository.php b/src/Bridge/Repository/AbstractEntityRepository.php
@@ -206,7 +206,7 @@ public function persist(mixed $entity): void
             $queryBuilder = $this->entityManager->getConnection()
                 ->createQueryBuilder()
                 ->update($this->entityManager->getTablesPrefix() . static::TABLE_NAME)
-                ->where(static::TABLE_IDENTIFIER, ':' . static::TABLE_IDENTIFIER)
+                ->where(static::TABLE_IDENTIFIER . ' = :' . static::TABLE_IDENTIFIER)
                 ->setParameter(static::TABLE_IDENTIFIER, $entity->{static::TABLE_IDENTIFIER})
             ;
 

diff --git a/test/Test/Bridge/Repository/PostRepositoryTest.php b/test/Test/Bridge/Repository/PostRepositoryTest.php
@@ -267,6 +267,10 @@ public function testPersistExistingPost(): void
 
         self::assertSame('Another post with a new title', $post->postTitle);
         self::assertSame('publish', $post->postStatus);
+
+        // Assert no collateral damages
+        $anotherPost = $this->repository->find(10);
+        self::assertSame('A post', $anotherPost->postTitle);
     }
 
     public function testDynamicSetter(): void