fix: add missing meta table join

williarin · Jul 25, 2024 · 17b7f8f · 17b7f8f
1 parent 3e1f8d8
commit 17b7f8f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/Bridge/Repository/AbstractEntityRepository.php b/src/Bridge/Repository/AbstractEntityRepository.php
@@ -825,6 +825,7 @@ private function selectColumns(QueryBuilder $queryBuilder, array $extraFields, S
             if (in_array($column, $extraFields, true)) {
                 $mappedMetaKey = $this->getMappedMetaKey($column);
                 $selects[] = select_from_eav($column, $mappedMetaKey);
+                $this->joinSelfMetaTable($queryBuilder);
             } elseif (str_starts_with($column, 'MAX(')) {
                 $selects[] = $column;
                 $this->joinSelfMetaTable($queryBuilder);

diff --git a/test/Test/Bridge/Repository/ProductRepositoryTest.php b/test/Test/Bridge/Repository/ProductRepositoryTest.php
@@ -552,4 +552,14 @@ public function testOperatorIsNotNullNested(): void
         self::assertContainsOnlyInstancesOf(Product::class, $products);
         self::assertEquals([17, 20, 23], array_column($products, 'id'));
     }
+
+    public function testSelectEntityFieldWithoutQueryingIt(): void
+    {
+        $product = $this->repository->findOneBy([
+            new SelectColumns(['id', 'sku']),
+            'post_title' => 'Hoodie',
+        ]);
+
+        $this->assertSame('woo-hoodie', $product->sku);
+    }
 }