New patch version for CRAN submission

willgearty · May 14, 2022 · 15c9de6 · 15c9de6
1 parent 988f1d6
commit 15c9de6
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 6 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: deeptime
 Title: Plotting Tools for Anyone Working in Deep Time
-Version: 0.2.1.9003
+Version: 0.2.2
 Authors@R: person("William", "Gearty", email = "[email protected]", role = c("aut", "cre"))
 Maintainer: William Gearty <[email protected]>
 Description: Extends the functionality of other plotting packages like

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,6 @@
-# development version
+# deeptime 0.2.2
 
+* Skip tests when suggested packages are unavailable
 * Added the ability to specify label color (#40)
 
 # deeptime 0.2.1

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,11 +1,28 @@
+## Resubmission
+This is a resubmission.
+
+* The gsloid package is now back on CRAN.
+
 ## Test environments (with Github Actions)
 
-* windows (x86_64-w64-mingw32), R 4.1.2
-* Mac OS X (x86_64-apple-darwin17.0), R 4.1.2
-* ubuntu 20.04 (x86_64-pc-linux-gnu), R 4.1.2 and devel (r81460)
+* windows (x86_64-w64-mingw32), R 4.2.0
+* Mac OS X (x86_64-apple-darwin17.0), R 4.2.0
+* ubuntu 20.04 (x86_64-pc-linux-gnu), R 4.2.0 and devel (r82335)
 
 ## R CMD check results
-There were no ERRORs, WARNINGs, or NOTEs.
+There were no ERRORs or WARNINGs.
+
+There were 2 NOTES:
+
+ * Package suggested but not available for checking: ‘gsloid’
+
+   gsloid is only used for tests and these tests are skipped if the package is not available.
+   Furthermore, this package appears to be under active development and should be restored to CRAN soon.
+
+ * Examples with CPU (user + system) or elapsed time > 5s
+
+   The identified example takes up to 7 seconds depending on the OS (but less than 5 seconds on Ubuntu).
+   The example is necessary to exemplify the functionality of the function.
 
 ## Downstream dependencies
 Checked 1 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

diff --git a/tests/testthat/test-gggeo_scale.R b/tests/testthat/test-gggeo_scale.R
@@ -19,6 +19,7 @@ test_that("gggeo_scale() works", {
   if(!suppressPackageStartupMessages(require(gsloid, quietly = TRUE))) {
     skip("gsloid not available for gggeo_scale")
   }
+  skip_if_offline(host = "macrostrat.org")
   p <- ggplot(lisiecki2005) +
     geom_line(aes(x = d18O, y = Time/1000), orientation = "y") +
     scale_y_reverse("Time (Ma)") +