Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplicial embedding component. #850

Merged
merged 2 commits into from
Dec 23, 2024

Only check for inversions if dimension can have inversion.

f3c7e6d
Select commit
Loading
Failed to load commit list.
Merged

Add simplicial embedding component. #850

Only check for inversions if dimension can have inversion.
f3c7e6d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 19, 2024 in 1s

68.42% of diff hit (target 75.00%)

View this Pull Request on Codecov

68.42% of diff hit (target 75.00%)

Annotations

Check warning on line 77 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L77 

Added line #L77 was not covered by tests

Check warning on line 106 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L106 

Added line #L106 was not covered by tests

Check warning on line 114 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L114 

Added line #L114 was not covered by tests

Check warning on line 117 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L117 

Added line #L117 was not covered by tests

Check warning on line 119 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L119 

Added line #L119 was not covered by tests

Check warning on line 243 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L241-L243 

Added lines #L241 - L243 were not covered by tests

Check warning on line 245 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L245 

Added line #L245 was not covered by tests

Check warning on line 249 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L249 

Added line #L249 was not covered by tests

Check warning on line 253 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L251-L253 

Added lines #L251 - L253 were not covered by tests

Check warning on line 257 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L257 

Added line #L257 was not covered by tests

Check warning on line 261 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L259-L261 

Added lines #L259 - L261 were not covered by tests

Check warning on line 266 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L265-L266 

Added lines #L265 - L266 were not covered by tests

Check warning on line 268 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L268 

Added line #L268 was not covered by tests

Check warning on line 274 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L271-L274 

Added lines #L271 - L274 were not covered by tests

Check warning on line 278 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L278 

Added line #L278 was not covered by tests

Check warning on line 282 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L280-L282 

Added lines #L280 - L282 were not covered by tests

Check warning on line 288 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L288 

Added line #L288 was not covered by tests

Check warning on line 290 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L290 

Added line #L290 was not covered by tests

Check warning on line 301 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L301 

Added line #L301 was not covered by tests

Check warning on line 304 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L304 

Added line #L304 was not covered by tests

Check warning on line 306 in components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/internal/SimplicialEmbedding.cpp#L306 

Added line #L306 was not covered by tests

Check warning on line 20 in components/simplicial_embedding/wmtk/components/simplicial_embedding/simplicial_embedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/simplicial_embedding.cpp#L20 

Added line #L20 was not covered by tests

Check warning on line 30 in components/simplicial_embedding/wmtk/components/simplicial_embedding/simplicial_embedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/simplicial_embedding/wmtk/components/simplicial_embedding/simplicial_embedding.cpp#L30 

Added line #L30 was not covered by tests

Check warning on line 116 in components/tests/simplicial_embedding/test_simplicial_embedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/tests/simplicial_embedding/test_simplicial_embedding.cpp#L116 

Added line #L116 was not covered by tests

Check warning on line 120 in components/tests/simplicial_embedding/test_simplicial_embedding.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/tests/simplicial_embedding/test_simplicial_embedding.cpp#L120 

Added line #L120 was not covered by tests
View more details on Codecov