Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

468-optimize-the-find_local_switch_sequence-function #469

Merged
merged 8 commits into from
Oct 26, 2023
Merged

468-optimize-the-find_local_switch_sequence-function #469

merged 8 commits into from
Oct 26, 2023

Conversation

zlyfunction
Copy link
Collaborator

see
#468

@zlyfunction zlyfunction changed the base branch from 466-add-local_switch_tuple-for-edgemesh to main October 19, 2023 05:16
@zlyfunction zlyfunction changed the title finish implementation for edge and traingle 468-optimize-the-find_local_switch_sequence-function Oct 19, 2023
@zlyfunction zlyfunction linked an issue Oct 19, 2023 that may be closed by this pull request
Optimize the find_local_switch_sequence function #468
Closed
2 tasks
@zlyfunction
Copy link
Collaborator Author

The new implementation is based on #467

@zlyfunction zlyfunction self-assigned this Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #469 (f0bb205) into main (803d3c5) will increase coverage by 0.40%.
The diff coverage is 96.26%.

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   85.37%   85.77%   +0.40%     
==========================================
  Files         187      187              
  Lines        5299     5386      +87     
==========================================
+ Hits         4524     4620      +96     
+ Misses        775      766       -9
Flag Coverage Δ
wildmeshing 85.77% <96.26%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...mtk/multimesh/utils/find_local_switch_sequence.cpp 95.90% <96.26%> (+27.33%) ⬆️

... and 1 file with indirect coverage changes

@zlyfunction zlyfunction mentioned this pull request Oct 19, 2023
Closed
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
5191fd0 
…lkit into 468-optimize-the-find_local_switch_sequence-function
@mtao mtao mentioned this pull request Oct 22, 2023
Open
@zlyfunction zlyfunction merged commit 3542219 into main Oct 26, 2023
9 checks passed
@zlyfunction zlyfunction deleted the 468-optimize-the-find_local_switch_sequence-function branch October 26, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtao mtao mtao left review comments

@JcDai JcDai JcDai approved these changes

@daniel-zint daniel-zint Awaiting requested review from daniel-zint

Assignees

@zlyfunction zlyfunction

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize the find_local_switch_sequence function
3 participants
@zlyfunction @mtao @JcDai