Major clenup #465

teseoch · 2023-10-18T18:19:08Z

No description provided.

daniel-zint

I'll do the full review as soon as the tests are running again.

CMakeLists.txt

codecov · 2023-10-18T21:51:37Z

Codecov Report

Merging #465 (c715f9b) into main (435ae49) will increase coverage by 1.71%.
The diff coverage is 63.60%.

@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   83.35%   85.07%   +1.71%     
==========================================
  Files         215      209       -6     
  Lines        5954     5788     -166     
==========================================
- Hits         4963     4924      -39     
+ Misses        991      864     -127

Flag	Coverage Δ
wildmeshing	`85.07% <63.60%> (+1.71%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
..._components/delaunay/internal/delaunay_geogram.cpp	`100.00% <100.00%> (ø)`
components/wmtk_components/input/input.cpp	`92.30% <100.00%> (+9.95%)`	⬆️
...ts/wmtk_components/input/internal/InputOptions.hpp	`100.00% <ø> (ø)`
components/wmtk_components/json_utils.hpp	`100.00% <100.00%> (ø)`
.../wmtk_components/output/internal/OutputOptions.hpp	`0.00% <ø> (ø)`
...components/regular_space/internal/RegularSpace.cpp	`100.00% <ø> (ø)`
...components/regular_space/internal/RegularSpace.hpp	`100.00% <ø> (ø)`
src/wmtk/Mesh.cpp	`76.19% <100.00%> (+0.12%)`	⬆️
src/wmtk/Mesh.hpp	`95.00% <ø> (ø)`
src/wmtk/PointMesh.hpp	`50.00% <ø> (ø)`
... and 51 more

... and 16 files with indirect coverage changes

…toolkit into remove-warnings

mtao · 2023-10-21T14:31:46Z

src/wmtk/io/MshReader.hpp

+class MshReader : public MeshReader
+{
+protected:
+    void read_aux(const std::filesystem::path& filename, Mesh& mesh) override;


i think you're still in the middle of writing things but it'd be good to have comments on what aux/cb are in this class

mtao · 2023-10-21T14:35:19Z

src/wmtk/operations/tri_mesh/EdgeCollapse.hpp

@@ -55,7 +55,7 @@ class EdgeCollapse : public TriMeshOperation, private TupleOperation

 private:
    Tuple m_output_tuple;
-    const OperationSettings<EdgeCollapse>& m_settings;
+    // const OperationSettings<EdgeCollapse>& m_settings;


why remove the settings? i think there is a future refactor to handle how we pass these settings around but for now this practice is the "way" we're doing things?

they were unused :)

Please open up an issue for that but do not just comment out stuff.

daniel-zint

There are several things that we need to discuss. Let's find some time soon.

This PR should have been at least 5 seperate PRs. Let's merge this asap and create follow-up issues. That's also the reason why I will only comment the PR and not request changes.

daniel-zint · 2023-11-01T15:21:16Z

components/wmtk_components/input/input.cpp

-            mesh.initialize(F);
-
-            mesh_utils::set_matrix_attribute(V, "position", PrimitiveType::Vertex, mesh);
+    auto mesh = MeshReader::read(options.file);


That won't do the job but we have issue already that reminds me that this needs to be fixed.

components/wmtk_components/isotropic_remeshing/isotropic_remeshing.cpp

components/wmtk_components/json_utils.hpp

components/wmtk_components/output/output.cpp

components/wmtk_components/regular_space/internal/RegularSpace.hpp

src/wmtk/operations/edge_mesh/EdgeOperationData.hpp

daniel-zint · 2023-11-01T15:43:32Z

src/wmtk/operations/tri_mesh/EdgeCollapse.hpp

@@ -55,7 +55,7 @@ class EdgeCollapse : public TriMeshOperation, private TupleOperation

 private:
    Tuple m_output_tuple;
-    const OperationSettings<EdgeCollapse>& m_settings;
+    // const OperationSettings<EdgeCollapse>& m_settings;


Please open up an issue for that but do not just comment out stuff.

src/wmtk/simplex/cofaces_single_dimension.cpp

src/wmtk/simplex/top_dimension_cofaces.cpp

src/wmtk/utils/triangle_areas.hpp

…ed area class

daniel-zint

lgtm

mtao

lgtm

teseoch added 2 commits October 18, 2023 11:06

switch to cpm

fb5d6e4

removed warnings

2cccc3a

teseoch requested review from mtao and daniel-zint October 18, 2023 18:19

minor fixes for release

2ac4dee

daniel-zint requested changes Oct 18, 2023

View reviewed changes

CMakeLists.txt Show resolved Hide resolved

teseoch and others added 2 commits October 18, 2023 14:14

minor error

fd6f7c4

linux warnings

1830bf7

teseoch added 3 commits October 19, 2023 14:29

cmake clenup, wildmeshing_toolkit builds

4175df9

finished cleanup

707e6b4

Merge branch 'remove-warnings' of github.com:wildmeshing/wildmeshing-…

2fc272b

…toolkit into remove-warnings

teseoch assigned teseoch, mtao and daniel-zint Oct 19, 2023

teseoch changed the title ~~Remove warnings~~ Major clenup Oct 19, 2023

teseoch added 3 commits October 19, 2023 16:55

updated paraviewo to avoid perl

0b7a2ce

refactored reader

5d02099

msh reader wip

cc38688

mtao reviewed Oct 21, 2023

View reviewed changes

teseoch added 2 commits October 23, 2023 11:41

msh reader and added top simplex to hdf5

02584b2

Merge branch 'main' into remove-warnings

283987d

teseoch marked this pull request as draft October 26, 2023 18:28

teseoch added 2 commits October 30, 2023 11:45

updated data with msh

e536e07

fixed test

a2a18ff

teseoch requested review from daniel-zint and mtao October 31, 2023 01:01

teseoch marked this pull request as ready for review October 31, 2023 01:01

teseoch added 2 commits October 31, 2023 09:55

Merge branch 'main' into remove-warnings

4f9aeb6

merge + remove warnings

c1814db

teseoch and others added 17 commits October 31, 2023 11:21

merging, image is back

2c08a6f

cleaned throw of string

733913c

removed image stuff

619e6eb

changed to debug in create

47efbac

undo

492f36a

fixed hdf5 writer

651da2d

typo in message

0163d05

smoothing test

1327c07

commented component_delaunay as input should be cloud

da8c5ec

linux

4a334a2

using test name as filename in testio

ba16aa8

gmp?

429ddf7

windows?

31af48a

serialization of path

97ddced

fix on msh reader

5d9806d

input option include

79b3a2f

test fix on windows

e354370

daniel-zint reviewed Nov 1, 2023

View reviewed changes

daniel-zint approved these changes Nov 1, 2023

View reviewed changes

teseo@sonic added 2 commits November 1, 2023 14:38

added comment for unused, json comment, refactored reader, and revert…

e0a6ece

…ed area class

added comment to msh reader

c715f9b

daniel-zint approved these changes Nov 1, 2023

View reviewed changes

mtao approved these changes Nov 1, 2023

View reviewed changes

teseoch merged commit 70d6c0f into main Nov 2, 2023
8 of 9 checks passed

teseoch deleted the remove-warnings branch November 2, 2023 14:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Major clenup #465

Major clenup #465

teseoch commented Oct 18, 2023

daniel-zint left a comment

codecov bot commented Oct 18, 2023 •

edited

Loading

mtao Oct 21, 2023

mtao Oct 21, 2023

teseoch Oct 31, 2023

daniel-zint Nov 1, 2023

daniel-zint left a comment

daniel-zint Nov 1, 2023

daniel-zint Nov 1, 2023

daniel-zint left a comment

mtao left a comment

Major clenup #465

Major clenup #465

Conversation

teseoch commented Oct 18, 2023

daniel-zint left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 18, 2023 • edited Loading

Codecov Report

mtao Oct 21, 2023

Choose a reason for hiding this comment

mtao Oct 21, 2023

Choose a reason for hiding this comment

teseoch Oct 31, 2023

Choose a reason for hiding this comment

daniel-zint Nov 1, 2023

Choose a reason for hiding this comment

daniel-zint left a comment

Choose a reason for hiding this comment

daniel-zint Nov 1, 2023

Choose a reason for hiding this comment

daniel-zint Nov 1, 2023

Choose a reason for hiding this comment

daniel-zint left a comment

Choose a reason for hiding this comment

mtao left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 18, 2023 •

edited

Loading