Adding top_cell_dimension to replace top_simplex_type as virtual #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to get a primitivetype
Codecov Report
@@ Coverage Diff @@
## main #444 +/- ##
==========================================
+ Coverage 82.71% 82.78% +0.06%
==========================================
Files 160 160
Lines 4496 4502 +6
==========================================
+ Hits 3719 3727 +8
+ Misses 777 775 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
top_cell_dimensionwas already planned for implementation for the sake of thePolygonMeshclass that @rjc8237 is working on, but I realized I wanted to implement a map from PrimitiveType -> dimension anyway for my MultiMesh refactor so I implemented it early.