Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed split/collapse from Mesh and customized Tri/Tet split/collapse #429

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

mtao
Copy link
Collaborator

@mtao mtao commented Oct 7, 2023

Split/collapse don't belong in the base mesh implementation as they are not atomic operations for all mesh types.
Instead each class (like TriMesh/TetMesh) is responsible for having its own member function for atomic operations.
Atomic operations also now return some sort of metadata (currently for the aforementioend types/operations some sort of EdgeOperationData).

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #429 (3f240eb) into main (19ec160) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   81.88%   81.95%   +0.07%     
==========================================
  Files         154      154              
  Lines        4156     4162       +6     
==========================================
+ Hits         3403     3411       +8     
+ Misses        753      751       -2     
Flag Coverage Δ
wildmeshing 81.95% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/wmtk/Mesh.hpp 94.44% <ø> (ø)
src/wmtk/PointMesh.hpp 25.00% <ø> (+8.33%) ⬆️
src/wmtk/TetMesh.cpp 86.34% <100.00%> (+0.09%) ⬆️
src/wmtk/TetMesh.hpp 100.00% <ø> (ø)
src/wmtk/TetMeshOperationExecutor.cpp 93.88% <100.00%> (-0.03%) ⬇️
src/wmtk/TriMesh.cpp 93.04% <100.00%> (+0.06%) ⬆️
src/wmtk/TriMesh.hpp 100.00% <ø> (ø)
src/wmtk/TriMeshOperationExecutor.cpp 96.51% <100.00%> (ø)
src/wmtk/operations/tet_mesh/EdgeOperationData.hpp 100.00% <100.00%> (ø)
src/wmtk/operations/tri_mesh/EdgeCollapse.cpp 78.72% <100.00%> (+0.94%) ⬆️
... and 2 more

@mtao mtao merged commit cadf64c into wildmeshing:main Oct 7, 2023
9 checks passed
@mtao mtao deleted the mtao/operations_output_exec_data branch October 7, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant