more verbose updates

applications/isotropic_remeshing/examples/raw/small.json

@@ -1,6 +1,7 @@
 {
     "input": {
         "path": "unit_test/meshes/small3d.msh",
+        "validate": true,
         "name_spec":
         "main"
     },

applications/isotropic_remeshing/main.cpp

@@ -125,6 +125,7 @@ int main(int argc, char* argv[])
     if(j.contains("intermediate_output_format")) {
         options.intermediate_output_format = j["intermediate_output_format"];
     }
+    assert(options.position_attribute.is_valid());
     wmtk::components::isotropic_remeshing::isotropic_remeshing(options);
 
     // input uv mesh

components/isotropic_remeshing/wmtk/components/isotropic_remeshing/IsotropicRemeshing.cpp

@@ -40,6 +40,9 @@ IsotropicRemeshing::~IsotropicRemeshing() = default;
 IsotropicRemeshing::IsotropicRemeshing(const IsotropicRemeshingOptions& opts)
     : m_options(opts)
 {
+    if(!m_options.position_attribute.is_valid()) {
+        throw std::runtime_error("Isotropic remeshing run without a valid position attribute");
+    }
     if (m_options.envelope_size.has_value()) {
         for (const auto& h : all_envelope_positions()) {
             auto envelope_invariant = std::make_shared<invariants::EnvelopeInvariant>(

components/isotropic_remeshing/wmtk/components/isotropic_remeshing/internal/configure_split.cpp

@@ -1,4 +1,5 @@
 #include "configure_split.hpp"
+#include <spdlog/spdlog.h>
 #include <wmtk/Mesh.hpp>
 #include <wmtk/invariants/InvariantCollection.hpp>
 #include <wmtk/invariants/MinEdgeLengthInvariant.hpp>
@@ -32,11 +33,13 @@ void configure_split(operations::EdgeSplit& es, Mesh& m, const IsotropicRemeshin
     auto invars = split_invariants(m, options);
     es.add_invariant(invars);
     for (auto& p : options.all_positions()) {
+        spdlog::info("Writng split attribute new for {}", p.name());
         es.set_new_attribute_strategy(p, operations::SplitBasicStrategy::None, operations::SplitRibBasicStrategy::Mean);
     }
     for (const auto& attr : options.pass_through_attributes) {
         es.set_new_attribute_strategy(attr);
     }
+    assert(es.attribute_new_all_configured());
 }
 
 } // namespace wmtk::components::isotropic_remeshing::internal

components/isotropic_remeshing/wmtk/components/isotropic_remeshing/isotropic_remeshing.cpp

@@ -7,6 +7,7 @@ namespace wmtk::components::isotropic_remeshing {
 
 void isotropic_remeshing(const IsotropicRemeshingOptions& options)
 {
+    assert(options.position_attribute.is_valid());
     IsotropicRemeshing app(options);
     app.run();
 }

src/wmtk/operations/EdgeSplit.cpp

@@ -20,7 +20,7 @@ bool EdgeSplit::attribute_new_all_configured() const
     for (const auto& strat : m_new_attr_strategies) {
         if (strat->invalid_state()) {
             all_configured = false;
-            wmtk::logger().warn("Attribute new {} was not configured", strat->name());
+            wmtk::logger().warn("Split attribute new {} was not configured", strat->name());
         }
     }
     return all_configured;

src/wmtk/utils/verify_simplex_index_valences.cpp

@@ -39,6 +39,7 @@ bool verify_simplex_index_valences(const Mesh& m, const internal::IndexSimplexMa
     constexpr static int meshD = get_primitive_type_id(mesh_pt);
     constexpr static int D = get_primitive_type_id(pt);
 
+
     std::vector<std::set<int64_t>> cofaces(mapper.simplices<D>().size());
     for (size_t j = 0; j < mapper.simplices<meshD>().size(); ++j) {
         for (const auto& face_index : mapper.faces<meshD, D>(j)) {
@@ -47,9 +48,10 @@ bool verify_simplex_index_valences(const Mesh& m, const internal::IndexSimplexMa
     }
 
     if (mesh_pt == pt + 1) {
-        for (const auto& cof : cofaces) {
+        for(size_t j = 0; j < cofaces.size(); ++j) {
+            const auto& cof = cofaces[j];
             if (cof.size() > 2) {
-                wmtk::logger().warn("More than 2 cofaces for a boundary simplex");
+                wmtk::logger().warn(fmt::format("More than 2 {}-cofaces (facet indices={}) for a boundary {}-simplex [{}]", D, fmt::join(cof,","), meshD, fmt::join(mapper.simplices<D>()[j],",")));
                 return false;
             }
         }
@@ -63,14 +65,16 @@ bool verify_simplex_index_valences(const Mesh& m, const internal::IndexSimplexMa
 
         std::array<int64_t, D + 1> i = indices<D>(m, mapper, s);
         const auto& cof2 = cofaces[mapper.get_index<D>(i)];
-        wmtk::logger().debug("Looking at {}-simplex {} on a {}", D, fmt::join(i, ","), meshD);
+        wmtk::logger().debug("Looking at {}-simplex {} on a {}-mesh", D, fmt::join(i, ","), meshD);
 
 
         if (cof.size() != cof2.size()) {
             wmtk::logger().warn(
-                "Cofaces size mismatch on simplex {}, mesh got (len{}), indices got [{}] "
+                "Cofaces size mismatch on {}-simplex {}, {}-mesh got (len{}), indices got [{}] "
                 "(len{})",
+                D,
                 fmt::join(i, ","),
+                meshD,
                 cof.size(),
                 fmt::join(cof2, ","),
                 cof2.size());