Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template and checks #617

Merged
merged 6 commits into from
Oct 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .scripts/check_proposals
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ end
class MetadataChecker
def initialize
@categories = load_all_categories()
@stability_levels = ["experimental", "preview", "community", "default"]
end

def check pr_number, front_matter
Expand All @@ -37,6 +38,25 @@ class MetadataChecker
else
system("gh pr edit #{pr_number} --remove-label invalid-categories")
end
issue_errors = check_issue(pr_number, front_matter)
if issue_errors.length() > 0
errors << issue_errors
system("gh pr edit #{pr_number} --add-label missing-issue")
else
system("gh pr edit #{pr_number} --remove-label missing-issue")
end
begin
stability_level, err = check_stability_level(pr_number, front_matter)
system("gh pr edit #{pr_number} --remove-label invalid-stability-level")
# remove any previous stability-levels
@stability_levels.map { | level | system("gh pr edit #{pr_number} --remove-label stability-level/#{level}") }
system("gh pr edit #{pr_number} --add-label stability-level/#{stability_level}")
rescue => error
errors << error.message
system("gh pr edit #{pr_number} --add-label invalid-stability-level")
@stability_levels.map { | level | system("gh pr edit #{pr_number} --remove-label stability-level/#{level}") }
end

errors
end

Expand All @@ -54,6 +74,22 @@ class MetadataChecker
errors
end

def check_issue pr_number, front_matter
errors = []
unless (front_matter.key? "issue") && (front_matter["issue"] != nil)
errors << "Missing field: issue"
end
errors
end

def check_stability_level pr_number, front_matter
unless (front_matter.key? "stability-level") && (@stability_levels.include? front_matter["stability-level"])
raise "Invalid field: stability-level"
else
return front_matter["stability-level"]
end
end

def load_all_categories
yaml = YAML.load_file("_data/wildfly-categories.yaml")
return yaml["categories"]
Expand Down
8 changes: 7 additions & 1 deletion _includes/index-categories.html
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,13 @@ <h2 id="{{ cat.id }}">{{ cat.name }} <small>[{{ cat.id }}]</small></a></h2>
{% for page in site.pages %}
<ul>
{% if page.categories contains cat.id %}
<li><a href="{{ site.baseurl }}{{ page.url }}">{{ page.title }}</a></li>
<li><a href="{{ site.baseurl }}{{ page.url }}">
{% if page.stability-level != nil and page.stability-level != "default" %}
[{{ page.stability-level | upcase }}]&nbsp;
{% endif %}

{{ page.title }}
</a></li>
{% endif %}
</ul>
{% endfor %}
Expand Down
10 changes: 9 additions & 1 deletion _layouts/proposal.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@

<div class="post-page grid-wrapper">
<div class="grid__item width-10-12">
<h1 class="title">{{page.title}}</h1>
<h1 class="title">
{% if page.stability-level != nil and page.stability-level != "default" %}
[{{ page.stability-level | upcase }}]&nbsp;
{% endif %}
{{page.title}}
</h1>
<div class="grid__item width-10-12 doc-content">

{% unless pages.categories == empty %}
Expand All @@ -14,6 +19,9 @@ <h1 class="title">{{page.title}}</h1>
{% endfor %}
</div>
{% endunless %}
<div style="padding-bottom: 2em;">Tracked by
<a href="{{ page.issue }}">{{ page.issue }}</a>
</div>

{{ content }}
</div>
Expand Down
5 changes: 3 additions & 2 deletions build/WFLY-19130_publish_Wildfly_channel_manifest.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
categories:
- wf-galleon
- maven
stability-level: community
---
= [Community] Publish WildFly channel manifest
= Publish WildFly channel manifest
:author: Bartosz Spyrko-Smietanko
:email: [email protected]
:toc: left
Expand Down Expand Up @@ -131,7 +132,7 @@ Following three channels will be created as part of this proposal:

|===

==== Manifest metadata Requirements
=== Manifest metadata Requirements

The manifest file defines a few metadata fields:
* name - human readable name of the manifest. Should contain the version of the server.
Expand Down
3 changes: 2 additions & 1 deletion controller/WFCORE-4868_configuration-files-aliases.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
categories:
- core
- management
stability-level: community
---
= [Community] Aliases for standard configuration files
= Aliases for standard configuration files
:author: Michal Petrov
:email: [email protected]
:toc: left
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
categories:
- core
- management
stability-level: community
---
= [Community] Simple config export for a server as an attachment for standalone or domain mode
= Simple config export for a server as an attachment for standalone or domain mode
:author: Emmanuel Hugonnet
:email: [email protected]
:toc: left
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
categories:
- core
- management
stability-level: default
---
= [Community] Simple config export for a server as an attachment for standalone or domain mode
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the '[Community]' here was a mistake, probably cut and paste from the earlier proposal for the community stability feature.

= Simple config export for a server as an attachment for standalone or domain mode
:author: Emmanuel Hugonnet
:email: [email protected]
:toc: left
Expand Down
125 changes: 49 additions & 76 deletions design-doc-template.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -4,119 +4,96 @@ categories:
# - core
# - management
# if missing, add it to _data/widfly-categories and use its id
#
# Specify the stability level of the feature.
# Values can be one of: experimental preview community default
stability-level:
#Specify the Feature Development tracker issue for the feature.
# This must be an issue tracked in https://github.com/orgs/wildfly/projects/7/views/1.
# To create a Feature Development tracker issue, go to https://github.com/wildfly/wildfly-proposals/issues/new/choose
# and select 'Feature Development'
issue:
---
= [Experimental|Preview|Community|default]Template <INSERT TITLE HERE>
= <INSERT TITLE HERE>
:author: Your Name
:email: [email protected]
:toc: left
:icons: font
:idprefix:
:idseparator: -

== Overview

== Issue Metadata

=== Issue

* https://issues.redhat.com/browse/WFCORE[WFCORE-XXXX]

=== Related Issues

* https://issues.redhat.com/browse/WFLY[WFLY-XXXX]

=== Stability Level
// Choose the planned stability level for the proposed functionality
* [ ] Experimental

* [ ] Preview
__<The entire document should be one to two pages long. We will write each analysis document as if it is a conversation with a future developer. This requires a good writing style, with full sentences organized into paragraphs. Bullets are acceptable only for visual style, not as an excuse for writing sentence fragments.>__

* [ ] Community

* [ ] default

=== Dev Contacts
== Overview

* mailto:{email}[{author}]
__<Define the requirement here. Be clear and succinct, you should be able to clearly define the context or problem in two or three paragraphs (if not sentences). Try to define the problem in the overall context and not to get into too much technical detail at this point.>__

=== QE Contacts
== Related Issues

=== Testing By
// Put an x in the relevant field to indicate if testing will be done by Engineering or QE.
// Discuss with QE during the Kickoff state to decide this
* [ ] Engineering
__<List the issues related to this feature>__

* [ ] QE
== Affected Projects or Components

=== Affected Projects or Components
__<List the projects or components that are affected by the feature. List them using their Git repositories.>__

=== Other Interested Projects

=== Relevant Installation Types
// Remove the x next to the relevant field if the feature in question is not relevant
// to that kind of WildFly installation
* [x] Traditional standalone server (unzipped or provisioned by Galleon)

* [x] Managed domain

* [x] OpenShift s2i
__<List the installation types thar are relevant for the features and remove any that are not relevant>__.

* [x] Bootable jar
* Traditional standalone server (unzipped or provisioned by Galleon)
* Managed domain
* OpenShift Source-to-Image (S2I)
* Bootable jar

== Requirements

=== Hard Requirements

=== Nice-to-Have Requirements
// Requirements in this section do not have to be met to merge the proposed functionality.
// Note: Nice-to-have requirements that don't end up being implemented as part of
// the work covered by this proposal should be moved to the 'Future Work' section.

__<Describe the requirements that must be fullfilled by this feature.>__

=== Non-Requirements
// Use this section to explicitly discuss things that readers might think are required
// but which are not required.

__<Use this section to explicitly discuss things that readers might think are required but which are not required.>__

=== Future Work
// Use this section to discuss requirements that are not addressed by this proposal
// but which may be addressed in later proposals.

__<Use this section to discuss requirements that are not addressed by this proposal but which may be addressed in later proposals.>__

== Backwards Compatibility

// Does this enhancement affect backwards compatibility with previously released
// versions of WildFly?
// Can the identified incompatibility be avoided?
__<Does this enhancement affect backwards compatibility with previously released versions of WildFly? Can the identified incompatibility be avoided?>__

=== Default Configuration

__<Does the proposed work change the default value of any current configuration attributes? Does it change the configuration generated by any current Galleon layers?>__

=== Importing Existing Configuration

__<Does the proposed work affect the ability to run WildFly running an existing configuration? Is there anything else about the proposed work that may require changes to the WildFly server migration tool?>__

=== Deployments

__<Does this feature change the behavior of deployments in incompatible ways?>__

=== Interoperability

//== Implementation Plan
////
Delete if not needed. The intent is if you have a complex feature which can
not be delivered all in one go to suggest the strategy. If your feature falls
into this category, please mention the Release Coordinators on the pull
request so they are aware.
////
__<Is this feature impacting interoperability?>__

== Implementation Plan

__<This section is optional. If you have a complex feature which can not be delivered all in one go, suggest the strategy.>__

== Admin Clients

__<Identify the level of compatibility this feature will have with the existing admin clients (JBoss CLI and the Admin Console / HAL). Identify any follow up work that will be required in the clients and link issues created to track this work.>__

== Security Considerations

////
Identification if any security implications that may need to be considered with this feature
or a confirmation that there are no security implications to consider.
////
__<What impact on security does this feature have?>__

== Test Plan

Depending on the selected stability level, the appropriate section below should be completed, including a brief description of how testing is to be performed in accordance with the selected stability level. The non-relevant sections may be removed as needed.
__<Depending on the selected stability level, the appropriate section below should be completed, including a brief description of how testing is to be performed in accordance with the selected stability level. The non-relevant sections may be removed as needed.>__
////
Depending on the stability level, the test plan required may vary. see below:
////
Expand All @@ -134,16 +111,12 @@ Depending on the stability level, the test plan required may vary. see below:
** Default - This stability level is reserved and requires approval by a professional Quality Engineer with subject matter expertise.

== Community Documentation
////
Generally a feature should have documentation as part of the PR to wildfly main, or as a follow up PR if the feature is in wildfly-core. In some cases though the documentation belongs more in a component, or does not need any documentation. Indicate which of these will happen.
////

__<Describe how this feature will be documented or illustrated. Generally a feature should have documentation as part of the PR to wildfly main, or as a follow up PR if the feature is in wildfly-core. In some cases though the feature will bring additional content (such as quickstarts, guides, etc.). Indicate which of these will happen>__
+** Default - This stability level is reserved and requires approval by a professional Quality Engineer with subject matter expertise.

== Release Note Content
////
Draft verbiage for up to a few sentences on the feature for inclusion in the
Release Note blog article for the release that first includes this feature.
Example article: http://wildfly.org/news/2018/08/30/WildFly14-Final-Released/.
This content will be edited, so there is no need to make it perfect or discuss
what release it appears in. "See Overview" is acceptable if the overview is
suitable. For simple features best covered as an item in a bullet-point list
of features containing a few words on each, use "Bullet point: <The few words>"
////

__<Draft verbiage for up to a few sentences on the feature for inclusion in the Release Note blog article for the release that first includes this feature.__
__Example article: https://www.wildfly.org/news/2024/01/25/WildFly31-Released/.__
__This content will be edited, so there is no need to make it perfect or discuss what release it appears in.>__
3 changes: 2 additions & 1 deletion ee/WFLY-19062-[PREVIEW]-Support_for_Jakarta_MVC_2.1.adoc
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
---
categories:
- ee
stability-level: preview
---
= [Preview] Standard WildFly support for Jakarta MVC 2.1
= Standard WildFly support for Jakarta MVC 2.1
:author: Brian Stansberry
:email: [email protected]
:toc: left
Expand Down
3 changes: 2 additions & 1 deletion elytron/WFLY-13762_ssl_context_based_on_peer_info.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
categories:
- elytron
- security
stability-level: community
---
= [Community] SSLContext to support delegation to alternate instances based on peer information
= SSLContext to support delegation to alternate instances based on peer information
:author: Diana Krepinska
:email: [email protected]
:toc: left
Expand Down
4 changes: 4 additions & 0 deletions elytron/WFLY-16306-keycloak-saml-feature-pack.adoc
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
---
categories:
- security
---
= WFLY-16306: Keycloak Galleon Feature Pack
:author: Farah Juma
:email: [email protected]
Expand Down
6 changes: 4 additions & 2 deletions elytron/WFLY-16532-additional-scope-for-auth-request.adoc
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
---
categories:
- elytron
- elytron
- security
stability-level: preview
---
== [Preview] Adding the ability to configure additional scope value for an authentication request
= Adding the ability to configure additional scope value for an authentication request
:author: Prarthona Paul
:email: [email protected]
:toc: left
Expand Down
8 changes: 7 additions & 1 deletion elytron/WFLY-17143-request-uri-parameters.adoc
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
= [Preview] Add the ability to specify that the OIDC Authentication Request should include request and request_uri parameters
---
categories:
- elytron
- security
stability-level: preview
---
= Add the ability to specify that the OIDC Authentication Request should include request and request_uri parameters
:author: Prarthona Paul
:email: [email protected]
:toc: left
Expand Down
Loading
Loading