Update template and checks #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmesnil
force-pushed
the
issue_stability_level_checks
branch
from
af28396
to
98c4b6c
Compare
bstansberry
requested changes
Jul 2, 2024
jmesnil
force-pushed
the
issue_stability_level_checks
branch
from
98c4b6c
to
0824288
Compare
jmesnil
force-pushed
the
issue_stability_level_checks
branch
from
daf030d
to
c2fea16
Compare
bstansberry
reviewed
Sep 12, 2024
jmesnil
force-pushed
the
issue_stability_level_checks
branch
5 times, most recently
from
bd003b7
to
7822862
Compare
jmesnil
commented
Sep 17, 2024
* Update the template to move the tracking issue and the stability level to the front matter * When a PR is open, check that these fields are valid * Generate a HTML page for the proposal with these fields. Signed-off-by: Jeff Mesnil <[email protected]>
Based on the value of the `stability-level` field in the front matter, add a label `stability-level/xxx` to the PR. Signed-off-by: Jeff Mesnil <[email protected]>
jmesnil
force-pushed
the
issue_stability_level_checks
branch
from
7822862
to
caae72f
Compare
bstansberry
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Hi @jmesnil -- I have a couple requests.
For context around these requests please have a look at https://docs.google.com/document/d/1e2hCAb--ApK32fPbUTWQSn6fH9GqmqZuaUPYwIp01JQ/edit. That's a draft of an email I plan to send to wildfly-dev once we merge this.
Merged
bstansberry
requested changes
Oct 3, 2024
* bring back Related Issues sections * clarify the issue metadata semantic Signed-off-by: Jeff Mesnil <[email protected]>
Signed-off-by: Jeff Mesnil <[email protected]>
|
@bstansberry I've updated the PR and made some suggestions to the mail you will send. thanks! |
|
I've created the labels that will be added to the PR based on their stability-level attributes:
|
|
@bstansberry Could we also merge #584? It would unclutter the PR queue. |
|
Thanks @jmesnil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the template to be more descriptive about its expected content.
As a demo, I opened a "dummy" proposal in my fork that was missing the
issueandstability-levelin the front matter:missing-issueandinvalid-stability-levellabels were automatically added to the PRstability-levelfield is valid in the front matter, add a label to the GitHub PR of the formstability-level/XXX(as seen on my fork at New feature jmesnil/wildfly-proposals#15)Before that PR is merged, the following labels must be created:
missing-issue- The analysis document is missing an issue tracker in its metadatainvalid-stability-level- The analysis document is missing a valid stability level in its metadatastability-level/experimental- Feature is at the "Experimental" stability levelstability-level/preview- Feature is at the "Preview" stability levelstability-level/community- Feature is at the "Community" stability levelstability-level/default- Feature is at the "Default" stability level