WIP #381
Closed
WIP #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmesnil
requested changes
Mar 15, 2021
core/yaml.adoc
Outdated
| The aim of this proposal is to be able to inject external configuration in a YAML format to WildFly in order to customize an existing configuration. | ||
| It is out of the scope of this proposal to provide support to define a complete server configuration in YAML: as such you won't be able to add a new extension using a YAML file. | ||
| We also want this to be *idempotent*: that means that starting and restarting the server with the same command line should produce the same result and shouldn't fail. | ||
| This feature is expected to be used as base for Bootable JAR implementation, it is not expected to be called directly by user (TODO get confirmation on this from Jeff and Brian and on how to 'hide' the feature). |
There was a problem hiding this comment.
this feature should not be hidden. It will be leveraged by the Bootable Jar Maven plugin
|
|
||
| === Issue | ||
|
|
||
| * https://issues.redhat.com/browse/WFCORE[WFCORE-XXXX] |
| External files will take precedence over the XML configuration ones. Then order will follow the command line. | ||
|
|
||
| * If the resource is already defined then all we have to du is updating its attrbiutes using the `write-attribute` operation. | ||
| * If the YAML part define an empty resource and the resource already exists: log a WARNING, otherwise try to add it. |
There was a problem hiding this comment.
why do you log a WARN and do not fail?
There was a problem hiding this comment.
Because it doesn't do anything, failing seems a bit 'harsh' and would add the resource if it was missing from the XML.
|
Superseded by ttps://github.com//pull/384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.