-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-7033] signature verification #6222
base: main
Are you sure you want to change the base?
Conversation
@yersan this is not a complete PR yet, but could you take a quick look at this and let me know if you're happy with this approach? |
Core -> Full Integration Build 14286 outcome was FAILURE using a merge of 0154a29 |
Core -> Full Integration Build 13992 outcome was FAILURE using a merge of 0154a29 |
Core -> WildFly Preview Integration Build 14063 outcome was FAILURE using a merge of 0154a29 |
Core -> WildFly Preview Integration Build 14072 outcome was FAILURE using a merge of 2106ab7 |
Core -> Full Integration Build 13999 outcome was FAILURE using a merge of 2106ab7 |
Core -> Full Integration Build 14293 outcome was FAILURE using a merge of 2106ab7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments with a quick look, I have not played with this yet, but overall approach looks good
...allation-manager/src/main/java/org/wildfly/core/instmgr/InstMgrCertificateImportHandler.java
Outdated
Show resolved
Hide resolved
installation-manager/src/main/java/org/wildfly/core/instmgr/InstMgrListUpdatesHandler.java
Outdated
Show resolved
Hide resolved
installation-manager/src/main/java/org/wildfly/core/instmgr/InstMgrPrepareRevertHandler.java
Outdated
Show resolved
Hide resolved
installation-manager/src/main/java/org/wildfly/core/instmgr/InstMgrPrepareUpdateHandler.java
Outdated
Show resolved
Hide resolved
installation-manager/src/main/java/org/wildfly/core/instmgr/InstMgrResourceDefinition.java
Outdated
Show resolved
Hide resolved
installation-manager/src/main/java/org/wildfly/core/instmgr/cli/ListCertificatesCommand.java
Show resolved
Hide resolved
installation-manager/src/main/java/org/wildfly/core/instmgr/cli/AddCertificatesCommand.java
Outdated
Show resolved
Hide resolved
installation-manager/src/main/java/org/wildfly/core/instmgr/cli/AddCertificatesCommand.java
Outdated
Show resolved
Hide resolved
installation-manager/src/main/java/org/wildfly/core/instmgr/cli/AddCertificatesCommand.java
Outdated
Show resolved
Hide resolved
installation-manager/src/main/java/org/wildfly/core/instmgr/cli/AddCertificatesCommand.java
Show resolved
Hide resolved
Core -> WildFly Preview Integration Build 14085 outcome was FAILURE using a merge of 673d837 |
Core -> Full Integration Build 14306 outcome was FAILURE using a merge of 673d837 |
Core -> Full Integration Build 14012 outcome was FAILURE using a merge of 673d837 |
673d837
to
3158ecd
Compare
Core -> WildFly Preview Integration Build 14086 outcome was FAILURE using a merge of 3158ecd |
Core -> Full Integration Build 14307 outcome was FAILURE using a merge of 3158ecd |
Core -> Full Integration Build 14013 outcome was FAILURE using a merge of 3158ecd |
Thanks @yersan! I updated the PR with your comments and made a few changes to work with the Web Console a bit easier. I'll create the wildfly-proposal and mark this as ready for review when that's ready |
JIRA: https://issues.redhat.com/browse/WFCORE-7033