[WFCORE-6750][Preview] Integrate the scanner for the unstable API annotations #5913

kabir · 2024-03-20T17:36:51Z

https://issues.redhat.com/browse/WFCORE-6750
Proposal: wildfly/wildfly-proposals#569

The library lives in https://github.com/wildfly/unstable-api-annotation-utils. Once approved I will release a 1.0.0.Final.

The full PR is wildfly/wildfly#17743 and needs this one merged before it can pass CI

github-actions · 2024-03-20T17:41:05Z

Dependency Tree Analyzer Output:

New Dependencies:

org.wildfly.unstable.api.annotation:unstable-api-annotation-classpath-indexer:jar:1.0.0.Beta1:compile

CC @wildfly/prod

...main/java/org/wildfly/extension/core/management/UnstableApiAnnotationResourceDefinition.java

...m/src/main/java/org/wildfly/extension/core/management/CoreManagementSubsystemSchema_1_0.java

rhusar · 2024-06-12T09:57:38Z

...system/src/main/resources/org/wildfly/extension/core/management/LocalDescriptions.properties

@@ -16,6 +16,11 @@ core-management.configuration-changes.remove=Remove the configuration changes an
 core-management.configuration-changes.max-history=The maximum number of configuration changes stored in history.
 core-management.configuration-changes.list-changes=List the last configuration changes.

+core-management.unstable-api-annotations=Service to configure how we deal with finding annotations indicating unstable api in user code.


rhusar · 2024-06-12T09:57:45Z

...system/src/main/resources/org/wildfly/extension/core/management/LocalDescriptions.properties

+core-management.unstable-api-annotations=Service to configure how we deal with finding annotations indicating unstable api in user code.
+core-management.unstable-api-annotations.add=Add the history for configuration changes.
+core-management.unstable-api-annotations.remove=Remove the configuration changes and clear the history.
+core-management.unstable-api-annotations.level=Whether to throw an error or log a warning if annotations indicating unstable api.


rhusar · 2024-06-12T10:00:23Z

...dfly/core/test/unstable/api/annotation/classes/_private/UnstableAnnotationApiTestLogger.java

+/*
+ *  JBoss, Home of Professional Open Source.
+ *  Copyright 2024 Red Hat, Inc., and individual contributors
+ *  as indicated by the @author tags.
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ *
+ */


If this is really new code we want to use the updated license header in Java files:

/* * Copyright The WildFly Authors * SPDX-License-Identifier: Apache-2.0 */

wildfly-ci · 2024-06-12T10:20:30Z

Core -> Full Integration Build 13598 outcome was FAILURE using a merge of 7d56a1e
Summary: Exit code 1 (Step: Build core (Maven)) (new) Build time: 00:00:21

wildfly-ci · 2024-06-12T10:20:44Z

Core -> WildFly Preview Integration Build 13660 outcome was FAILURE using a merge of 7d56a1e
Summary: Exit code 1 (Step: Build core (Maven)) (new) Build time: 00:00:34

wildfly-ci · 2024-06-12T10:20:57Z

Core -> Full Integration Build 13864 outcome was FAILURE using a merge of 7d56a1e
Summary: Exit code 1 (Step: Build core (Maven)) (new) Build time: 00:00:47

All done!

wildfly-ci · 2024-06-12T12:37:14Z

Core -> Full Integration Build 13599 outcome was FAILURE using a merge of f096b56
Summary: Tests failed: 2 (2 new), passed: 3960, ignored: 61 Build time: 02:12:07

Failed tests

org.jboss.as.test.layers.base.LayersTestCase.testUnreferencedModules: java.lang.AssertionError: Some alias modules are referenced org.jboss.jandex
	at org.jboss.as.test.layers.LayersTest.testUnreferencedModules(LayersTest.java:241)
	at org.jboss.as.test.shared.LayersTestBase.testUnreferencedModules(LayersTestBase.java:423)
	at org.jboss.as.test.layers.base.LayersTestCase.testUnreferencedModules(LayersTestCase.java:24)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
------- Stderr: -------
Could not load Logmanager "org.jboss.logmanager.LogManager"
java.lang.ClassNotFoundException: org.jboss.logmanager.LogManager
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
	at java.logging/java.util.logging.LogManager$1.run(LogManager.java:239)
	at java.logging/java.util.logging.LogManager$1.run(LogManager.java:223)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.logging/java.util.logging.LogManager.<clinit>(LogManager.java:223)
	at org.jboss.logging.LoggerProviders.tryJBossLogManager(LoggerProviders.java:139)
	at org.jboss.logging.LoggerProviders.findProvider(LoggerProviders.java:80)
	at org.jboss.logging.LoggerProviders.find(LoggerProviders.java:32)
	at org.jboss.logging.LoggerProviders.<clinit>(LoggerProviders.java:29)
	at org.jboss.logging.Logger.getLogger(Logger.java:2465)
	at org.jboss.logging.Logger.getLogger(Logger.java:2491)
	at org.jboss.as.test.shared.util.AssumeTestGroupUtil.<clinit>(AssumeTestGroupUtil.java:46)
	at org.jboss.as.test.layers.base.LayersTestCase.testUnreferencedModules(LayersTestCase.java:22)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)


org.jboss.as.test.layers.expansion.LayersTestCase.testUnreferencedModules: java.lang.AssertionError: Some alias modules are referenced org.jboss.jandex
	at org.jboss.as.test.layers.LayersTest.testUnreferencedModules(LayersTest.java:241)
	at org.jboss.as.test.shared.LayersTestBase.testUnreferencedModules(LayersTestBase.java:423)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
------- Stderr: -------
Could not load Logmanager "org.jboss.logmanager.LogManager"
java.lang.ClassNotFoundException: org.jboss.logmanager.LogManager
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
	at java.logging/java.util.logging.LogManager$1.run(LogManager.java:239)
	at java.logging/java.util.logging.LogManager$1.run(LogManager.java:223)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.logging/java.util.logging.LogManager.<clinit>(LogManager.java:223)
	at org.jboss.logging.LoggerProviders.tryJBossLogManager(LoggerProviders.java:139)
	at org.jboss.logging.LoggerProviders.findProvider(LoggerProviders.java:80)
	at org.jboss.logging.LoggerProviders.find(LoggerProviders.java:32)
	at org.jboss.logging.LoggerProviders.<clinit>(LoggerProviders.java:29)
	at org.jboss.logging.Logger.getLogger(Logger.java:2465)
	at org.jboss.logging.Logger.getLogger(Logger.java:2491)
	at org.jboss.as.test.shared.util.AssumeTestGroupUtil.<clinit>(AssumeTestGroupUtil.java:46)
	at org.jboss.as.test.layers.expansion.LayersTestCase.getExpectedUnreferenced(LayersTestCase.java:14)
	at org.jboss.as.test.shared.LayersTestBase.testUnreferencedModules(LayersTestBase.java:423)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

wildfly-ci · 2024-06-12T13:31:24Z

Core -> WildFly Preview Integration Build 13661 outcome was FAILURE using a merge of f096b56
Summary: Tests failed: 1 (1 new), passed: 5007, ignored: 84 Build time: 03:06:16

Failed tests

org.jboss.as.test.layers.expansion.LayersTestCase.testUnreferencedModules: java.lang.AssertionError: Some alias modules are referenced org.jboss.jandex
	at org.jboss.as.test.layers.LayersTest.testUnreferencedModules(LayersTest.java:241)
	at org.jboss.as.test.shared.LayersTestBase.testUnreferencedModules(LayersTestBase.java:423)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
------- Stderr: -------
Could not load Logmanager "org.jboss.logmanager.LogManager"
java.lang.ClassNotFoundException: org.jboss.logmanager.LogManager
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
	at java.logging/java.util.logging.LogManager$1.run(LogManager.java:239)
	at java.logging/java.util.logging.LogManager$1.run(LogManager.java:223)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:318)
	at java.logging/java.util.logging.LogManager.<clinit>(LogManager.java:222)
	at org.jboss.logging.LoggerProviders.tryJBossLogManager(LoggerProviders.java:139)
	at org.jboss.logging.LoggerProviders.findProvider(LoggerProviders.java:80)
	at org.jboss.logging.LoggerProviders.find(LoggerProviders.java:32)
	at org.jboss.logging.LoggerProviders.<clinit>(LoggerProviders.java:29)
	at org.jboss.logging.Logger.getLogger(Logger.java:2465)
	at org.jboss.logging.Logger.getLogger(Logger.java:2491)
	at org.jboss.as.test.shared.util.AssumeTestGroupUtil.<clinit>(AssumeTestGroupUtil.java:46)
	at org.jboss.as.test.layers.expansion.LayersTestCase.getExpectedUnreferenced(LayersTestCase.java:14)
	at org.jboss.as.test.shared.LayersTestBase.testUnreferencedModules(LayersTestBase.java:423)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

ehsavoie

Just a small provisioning question

ehsavoie · 2024-06-17T15:51:12Z

...n/resources/modules/system/layers/base/org/wildfly/extension/core-management/main/module.xml

        <module name="org.wildfly.extension.core-management-client"/>
        <module name="org.wildfly.security.elytron-private"/>
        <module name="org.wildfly.service"/>
+        <module name="org.wildfly.unstable.annotation.api.indexer"/>
+        <module name="org.wildfly._internal.unstable-api-annotation-index"/>


Shouldn't those modules be optional

@ehsavoie The indices and the dependency on the scanner need to always be added, or we would need a layer which doesn't seem practical for a preview feature. A bit further down the line (once this reaches community level) I would like to add a layer which enables the configuration to turn the scanning on. But still there is a hard dependency on the indexer

Ok, I was wondering about adding all those indexes and jars if one just doesn't want the feature

wildfly-ci · 2024-06-21T19:09:12Z

Core -> WildFly Preview Integration Build 13685 outcome was FAILURE using a merge of 718d766
Summary: Tests failed: 1 (1 new), passed: 4974, ignored: 85 Build time: 03:24:06

Failed tests

org.wildfly.test.integration.elytron.oidc.client.subsystem.OidcWithSubsystemConfigTest(layers-test): org.wildfly.test.integration.elytron.oidc.client.subsystem.OidcWithSubsystemConfigTest(layers-test).org.wildfly.test.integration.elytron.oidc.client.subsystem.OidcWithSubsystemConfigTest: java.lang.AssertionError
	at org.wildfly.test.integration.elytron.oidc.client.OidcBaseTest.sendRealmCreationRequest(OidcBaseTest.java:120)
	at org.wildfly.test.integration.elytron.oidc.client.subsystem.OidcWithSubsystemConfigTest$KeycloakAndSubsystemSetup.setup(OidcWithSubsystemConfigTest.java:185)
	at org.jboss.as.arquillian.container.ServerSetupObserver$ServerSetupTaskHolder.setup(ServerSetupObserver.java:249)
	at org.jboss.as.arquillian.container.ServerSetupObserver.executeSetup(ServerSetupObserver.java:180)
	at org.jboss.as.arquillian.container.ServerSetupObserver.handleBeforeDeployment(ServerSetupObserver.java:113)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor42.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor32.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor27.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
------- Stdout: -------
 [0m18:36:14,932 INFO  [org.jboss.as.repository] (management-handler-thread - 1) WFLYDR0001: Content added at location /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/elytron-oidc-client/target/wildfly/standalone/data/content/7f/1ba125dfda70e004563b0a96f13375701161db/content
 [0m [0m18:36:14,939 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-2) WFLYSRV0027: Starting deployment of "arquillian-service" (runtime-name: "arquillian-service")
 [0m [33m18:36:15,251 WARN  [org.jboss.as.dependency.private] (MSC service thread 1-8) WFLYSRV0018: Deployment "deployment.arquillian-service" is using a private module ("org.jboss.jandex") which may be changed or removed in future versions without notice.
 [0m [33m18:36:15,252 WARN  [org.jboss.as.dependency.private] (MSC service thread 1-8) WFLYSRV0018: Deployment "deployment.arquillian-service" is using a private module ("org.wildfly.security.manager") which may be changed or removed in future versions without notice.
 [0m [33m18:36:15,252 WARN  [org.jboss.as.dependency.private] (MSC service thread 1-8) WFLYSRV0018: Deployment "deployment.arquillian-service" is using a private module ("org.jboss.as.jmx") which may be changed or removed in future versions without notice.
 [0m [33m18:36:15,252 WARN  [org.jboss.as.dependency.private] (MSC service thread 1-8) WFLYSRV0018: Deployment "deployment.arquillian-service" is using a private module ("org.jboss.as.server") which may be changed or removed in future versions without notice.
 [0m [33m18:36:15,252 WARN  [org.jboss.as.dependency.private] (MSC service thread 1-8) WFLYSRV0018: Deployment "deployment.arquillian-service" is using a private module ("org.wildfly.common") which may be changed or removed in future versions without notice.
 [0m [33m18:36:15,261 WARN  [org.jboss.weld.deployer] (MSC service thread 1-8) WFLYWELD0013: Deployment arquillian-service contains Jakarta Contexts and Dependency Injection annotations but no bean archive was found (no beans.xml or class with bean defining annotations was present).
 [0m [0m18:36:15,276 INFO  [org.jboss.as.server] (management-handler-thread - 1) WFLYSRV0010: Deployed "arquillian-service" (runtime-name : "arquillian-service")
 [0m [0m18:39:43,862 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-6) WFLYUT0019: Host default-host stopping
 [0m [0m18:39:43,869 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-5) WFLYUT0008: Undertow HTTP listener default suspending
 [0m [0m18:39:43,871 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-5) WFLYUT0007: Undertow HTTP listener default stopped, was bound to 127.0.0.1:8080
 [0m [0m18:39:43,871 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-7) WFLYUT0004: Undertow 2.3.14.Final stopping
 [0m [0m18:39:43,879 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-8) WFLYSRV0028: Stopped deployment arquillian-service (runtime-name: arquillian-service) in 20ms
 [0m [0m18:39:43,890 INFO  [org.jboss.as] (MSC service thread 1-4) WFLYSRV0050: WildFly Preview 33.0.0.Beta1-SNAPSHOT (WildFly Core 25.0.0.Beta5-SNAPSHOT) stopped in 32ms
 [0m [0m18:39:43,894 INFO  [org.jboss.as] (MSC service thread 1-8) WFLYSRV0049: WildFly Preview 33.0.0.Beta1-SNAPSHOT (WildFly Core 25.0.0.Beta5-SNAPSHOT) starting
 [0m [0m18:39:44,091 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
 [0m [0m18:39:44,108 INFO  [org.wildfly.extension.elytron.oidc._private] (ServerService Thread Pool -- 34) WFLYOIDC0001: Activating WildFly Elytron OIDC Subsystem
 [0m [0m18:39:44,113 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 35) WFLYCLINF0001: Activating Infinispan subsystem.
 [0m [33m18:39:44,119 WARN  [org.wildfly.extension.elytron] (MSC service thread 1-7) WFLYELY00023: KeyStore file '/opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/elytron-oidc-client/target/wildfly/standalone/configuration/application.keystore' does not exist. Used blank.
 [0m [33m18:39:44,120 WARN  [org.wildfly.extension.elytron] (MSC service thread 1-8) WFLYELY01084: KeyStore /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/elytron-oidc-client/target/wildfly/standalone/configuration/application.keystore not found, it will be auto-generated on first use with a self-signed certificate for host localhost

wildfly-ci · 2024-06-21T20:00:31Z

Core -> Full Integration Build 13889 outcome was FAILURE using a merge of 718d766
Summary: Tests failed: 1 (1 new), passed: 5836, ignored: 113 Build time: 04:15:26

Failed tests

TestSuite: org.eclipse.microprofile.fault.tolerance.tck.TimeoutTest.testGTShorterTimeoutOverride: java.lang.AssertionError: serviceB should throw a TimeoutException in testGTShorterTimeoutOverride not a RuntimeException
	at deployment.ftTimeout.war//org.testng.Assert.fail(Assert.java:99)
	at deployment.ftTimeout.war//org.eclipse.microprofile.fault.tolerance.tck.TimeoutTest.testGTShorterTimeoutOverride(TimeoutTest.java:329)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at deployment.ftTimeout.war//org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:133)
	at deployment.ftTimeout.war//org.testng.internal.MethodInvocationHelper$1.runTestMethod(MethodInvocationHelper.java:239)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor277.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor276.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor275.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at deployment.ftTimeout.war//org.testng.internal.MethodInvocationHelper.invokeHookable(MethodInvocationHelper.java:253)
	at deployment.ftTimeout.war//org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:594)
	at deployment.ftTimeout.war//org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:173)
	at deployment.ftTimeout.war//org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
	at deployment.ftTimeout.war//org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:824)
	at deployment.ftTimeout.war//org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:146)
	at deployment.ftTimeout.war//org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
	at deployment.ftTimeout.war//org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at deployment.ftTimeout.war//org.testng.TestRunner.privateRun(TestRunner.java:794)
	at deployment.ftTimeout.war//org.testng.TestRunner.run(TestRunner.java:596)
	at deployment.ftTimeout.war//org.testng.SuiteRunner.runTest(SuiteRunner.java:377)
	at deployment.ftTimeout.war//org.testng.SuiteRunner.runSequentially(SuiteRunner.java:371)
	at deployment.ftTimeout.war//org.testng.SuiteRunner.privateRun(SuiteRunner.java:332)
	at deployment.ftTimeout.war//org.testng.SuiteRunner.run(SuiteRunner.java:276)
	at deployment.ftTimeout.war//org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
	at deployment.ftTimeout.war//org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
	at deployment.ftTimeout.war//org.testng.TestNG.runSuitesSequentially(TestNG.java:1212)
	at deployment.ftTimeout.war//org.testng.TestNG.runSuitesLocally(TestNG.java:1134)
	at deployment.ftTimeout.war//org.testng.TestNG.runSuites(TestNG.java:1063)
	at deployment.ftTimeout.war//org.testng.TestNG.run(TestNG.java:1031)
	at [email protected]//jakarta.servlet.http.HttpServlet.service(HttpServlet.java:527)
	at [email protected]//jakarta.servlet.http.HttpServlet.service(HttpServlet.java:614)
	at [email protected]//io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74)
	at [email protected]//io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62)
	at [email protected]//io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68)
	at [email protected]//io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36)
	at [email protected]//org.wildfly.elytron.web.undertow.server.ElytronRunAsHandler.lambda$handleRequest$1(ElytronRunAsHandler.java:68)
	at [email protected]//org.wildfly.security.auth.server.FlexibleIdentityAssociation.runAsFunctionEx(FlexibleIdentityAssociation.java:103)
	at [email protected]//org.wildfly.security.auth.server.Scoped.runAsFunctionEx(Scoped.java:161)
	at [email protected]//org.wildfly.security.auth.server.Scoped.runAs(Scoped.java:73)

...main/java/org/wildfly/extension/core/management/UnstableApiAnnotationResourceDefinition.java

...rc/main/java/org/wildfly/extension/core/management/CoreManagementRootResourceDefinition.java

...m/src/main/java/org/wildfly/extension/core/management/CoreManagementSubsystemSchema_1_0.java

...rc/test/java/org/wildfly/extension/core/management/CoreManagementSubsystem_1_0_TestCase.java

...system/src/main/java/org/wildfly/extension/core/management/UnstableApiAnnotationService.java

...rc/main/java/org/wildfly/extension/core/management/CoreManagementRootResourceDefinition.java

...main/java/org/wildfly/extension/core/management/UnstableApiAnnotationResourceDefinition.java

.../java/org/wildfly/extension/core/management/deployment/UnstableApiAnnotationAttachments.java

yersan · 2024-06-25T15:12:07Z

@kabir @pferraro @rhusar @ehsavoie thanks! 🍻

kabir mentioned this pull request Mar 20, 2024

[WFLY-19152] Add indices of APIs annotated with annotations indicating unstable API wildfly/wildfly#17743

Merged

github-actions bot added the deps-changed Dependencies have been checked, and there are changes highlighted in a comment label Mar 20, 2024

bstansberry added Feature This PR adds a new feature to WildFly missing-reqs This PR is missing external requirements before it can be merged labels Mar 24, 2024

pferraro previously requested changes Mar 29, 2024

View reviewed changes

...main/java/org/wildfly/extension/core/management/UnstableApiAnnotationResourceDefinition.java Show resolved Hide resolved

...m/src/main/java/org/wildfly/extension/core/management/CoreManagementSubsystemSchema_1_0.java Outdated Show resolved Hide resolved

kabir force-pushed the experimental-annotation-poc2 branch from fe1cd49 to d26d428 Compare April 15, 2024 06:18

kabir force-pushed the experimental-annotation-poc2 branch from d26d428 to 5d6eb7a Compare April 29, 2024 13:38

kabir marked this pull request as ready for review April 29, 2024 13:38

wildfly deleted a comment from wildfly-ci Jun 3, 2024

rhusar suggested changes Jun 12, 2024

View reviewed changes

kabir force-pushed the experimental-annotation-poc2 branch from 5d6eb7a to 7d56a1e Compare June 12, 2024 10:17

kabir force-pushed the experimental-annotation-poc2 branch from 7d56a1e to f096b56 Compare June 12, 2024 10:22

kabir force-pushed the experimental-annotation-poc2 branch from f096b56 to 6717755 Compare June 12, 2024 14:41

ehsavoie approved these changes Jun 20, 2024

View reviewed changes

kabir force-pushed the experimental-annotation-poc2 branch 2 times, most recently from 7941c34 to 718d766 Compare June 21, 2024 15:51

ehsavoie approved these changes Jun 24, 2024

View reviewed changes

pferraro requested changes Jun 24, 2024

View reviewed changes

kabir added 2 commits June 24, 2024 15:53

[WFCORE-6750] Integrate the unstable api annotation scanner

4084e22

[WFCORE-6750] Update to 1.0.0.Beta1 of the scanner & zip indices

e25403d

kabir force-pushed the experimental-annotation-poc2 branch from 718d766 to 7453eb3 Compare June 24, 2024 15:05

kabir requested a review from pferraro June 24, 2024 15:07

pferraro reviewed Jun 24, 2024

View reviewed changes

...main/java/org/wildfly/extension/core/management/UnstableApiAnnotationResourceDefinition.java Outdated Show resolved Hide resolved

pferraro reviewed Jun 24, 2024

View reviewed changes

.../java/org/wildfly/extension/core/management/deployment/UnstableApiAnnotationAttachments.java Outdated Show resolved Hide resolved

[WFCORE-6750] Code review fixes

77c2b08

kabir force-pushed the experimental-annotation-poc2 branch from 7453eb3 to 77c2b08 Compare June 24, 2024 15:40

pferraro approved these changes Jun 25, 2024

View reviewed changes

yersan changed the title ~~[WFCORE-6750] Integrate the scanner for the unstable API annotations~~ [WFCORE-6750][Preview] Integrate the scanner for the unstable API annotations Jun 25, 2024

yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jun 25, 2024

yersan merged commit 9068189 into wildfly:main Jun 25, 2024
12 checks passed

yersan removed the missing-reqs This PR is missing external requirements before it can be merged label Jun 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WFCORE-6750][Preview] Integrate the scanner for the unstable API annotations #5913

[WFCORE-6750][Preview] Integrate the scanner for the unstable API annotations #5913

kabir commented Mar 20, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024 •

edited

Loading

rhusar Jun 12, 2024

rhusar Jun 12, 2024

rhusar Jun 12, 2024

wildfly-ci commented Jun 12, 2024

wildfly-ci commented Jun 12, 2024

wildfly-ci commented Jun 12, 2024

wildfly-ci commented Jun 12, 2024

wildfly-ci commented Jun 12, 2024

ehsavoie left a comment

ehsavoie Jun 17, 2024

kabir Jun 21, 2024

ehsavoie Jun 21, 2024

wildfly-ci commented Jun 21, 2024

wildfly-ci commented Jun 21, 2024

yersan commented Jun 25, 2024

[WFCORE-6750][Preview] Integrate the scanner for the unstable API annotations #5913

[WFCORE-6750][Preview] Integrate the scanner for the unstable API annotations #5913

Conversation

kabir commented Mar 20, 2024 • edited Loading

github-actions bot commented Mar 20, 2024 • edited Loading

rhusar Jun 12, 2024

Choose a reason for hiding this comment

rhusar Jun 12, 2024

Choose a reason for hiding this comment

rhusar Jun 12, 2024

Choose a reason for hiding this comment

wildfly-ci commented Jun 12, 2024

wildfly-ci commented Jun 12, 2024

wildfly-ci commented Jun 12, 2024

wildfly-ci commented Jun 12, 2024

Failed tests

wildfly-ci commented Jun 12, 2024

Failed tests

ehsavoie left a comment

Choose a reason for hiding this comment

ehsavoie Jun 17, 2024

Choose a reason for hiding this comment

kabir Jun 21, 2024

Choose a reason for hiding this comment

ehsavoie Jun 21, 2024

Choose a reason for hiding this comment

wildfly-ci commented Jun 21, 2024

Failed tests

wildfly-ci commented Jun 21, 2024

Failed tests

yersan commented Jun 25, 2024

kabir commented Mar 20, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024 •

edited

Loading