New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename JSF to Jakarta Faces, remove outdated comment in beans.xml, up… #107

Open

WolfgangHG wants to merge 1 commit into wildfly:main from WolfgangHG:jakartafaces

Contributor

WolfgangHG commented Sep 3, 2024 •

edited

Loading

...date properties in persistence.xml

A bit of cleanup:

JSF / "Java Server Faces" was renamed to "Jakarta Faces"
there was a comment in beans.xml pointing to https://issues.redhat.com/browse/WFLY-13306. The original error when deploying an empty project without "beans.xml" does not happen any more, so I removed the comment and stated that the file is optional. It could also be deleted, but I consider it helpful to have stubs for all relevant deployment descriptors.

"persistence.xml" caused a deployment warning:

19:23:20,269 WARN  [org.hibernate.orm.deprecation] (ServerService Thread Pool -- 94) HHH90000021: Encountered deprecated setting [javax.persistence.schema-generation.database.action], use [jakarta.persistence.schema-generation.database.action] instead

So I renamed those properties.


          Rename JSF to Jakarta Faces, remove outdated comment in beans.xml, up…

e54fce1

…date properties in persistence.xml

WolfgangHG requested review from emmartins, bstansberry, jmesnil, jamezp and darranl as code owners

September 3, 2024 17:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

emmartins Awaiting requested review from emmartins emmartins is a code owner

bstansberry Awaiting requested review from bstansberry bstansberry is a code owner

jmesnil Awaiting requested review from jmesnil jmesnil is a code owner

jamezp Awaiting requested review from jamezp jamezp is a code owner

darranl Awaiting requested review from darranl darranl is a code owner

Labels

None yet