Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-19629] set bootableJarName in bootable-jar profile #946

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/quickstart_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ jobs:
echo "Building bootable jar..."
mvn -fae clean ${{ inputs.MVN_COMMAND }} -Pbootable-jar
echo "Starting bootable jar..."
mvn -f ${{ inputs.DEPLOYMENT_DIR }}/pom.xml wildfly:start-jar -Dstartup-timeout=120 ${{ inputs.EXTRA_RUN_ARGS }}
mvn -f ${{ inputs.DEPLOYMENT_DIR }}/pom.xml wildfly:start-jar -Dbootable-jar-name=${{ inputs.QUICKSTART_PATH }}-bootable.jar -Dstartup-timeout=120 ${{ inputs.EXTRA_RUN_ARGS }}
echo "Testing bootable jar..."
mvn -fae verify -Dserver.host=${{ inputs.SERVER_PROVISIONING_SERVER_HOST }} -Pintegration-testing
echo "Shutting down bootable jar..."
Expand Down Expand Up @@ -241,7 +241,7 @@ jobs:
echo "Building bootable jar..."
mvn -fae clean ${{ inputs.MVN_COMMAND }} -Pbootable-jar -Dversion.server=${{ needs.wildfly-build.outputs.wildfly-version }}
echo "Starting bootable jar..."
mvn -f ${{ inputs.DEPLOYMENT_DIR }}/pom.xml wildfly:start-jar -Dstartup-timeout=120 ${{ inputs.EXTRA_RUN_ARGS }}
mvn -f ${{ inputs.DEPLOYMENT_DIR }}/pom.xml wildfly:start-jar -Dbootable-jar-name=${{ inputs.QUICKSTART_PATH }}-bootable.jar -Dstartup-timeout=120 ${{ inputs.EXTRA_RUN_ARGS }}
echo "Testing bootable jar..."
mvn -fae verify -Dserver.host=${{ inputs.SERVER_PROVISIONING_SERVER_HOST }} -Pintegration-testing
echo "Shutting down bootable jar..."
Expand Down
1 change: 1 addition & 0 deletions micrometer/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1204,6 +1204,7 @@ The quickstart `pom.xml` file contains a Maven profile named *bootable-jar* whic
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
<add-ons>...</add-ons>
</configuration>
<executions>
Expand Down
1 change: 1 addition & 0 deletions microprofile-config/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1393,6 +1393,7 @@ The quickstart `pom.xml` file contains a Maven profile named *bootable-jar* whic
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
<add-ons>...</add-ons>
</configuration>
<executions>
Expand Down
1 change: 1 addition & 0 deletions microprofile-config/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
</configuration>
<executions>
<execution>
Expand Down
1 change: 1 addition & 0 deletions microprofile-fault-tolerance/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1224,6 +1224,7 @@ The quickstart `pom.xml` file contains a Maven profile named *bootable-jar* whic
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
<add-ons>...</add-ons>
</configuration>
<executions>
Expand Down
2 changes: 1 addition & 1 deletion microprofile-fault-tolerance/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@
Rename the output war to ROOT.war before adding it to the server, so that the
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
</configuration>
<executions>
<execution>
Expand Down
1 change: 1 addition & 0 deletions microprofile-health/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1073,6 +1073,7 @@ The quickstart `pom.xml` file contains a Maven profile named *bootable-jar* whic
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
<add-ons>...</add-ons>
</configuration>
<executions>
Expand Down
2 changes: 1 addition & 1 deletion microprofile-health/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@
Rename the output war to ROOT.war before adding it to the server, so that the
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
</configuration>
<executions>
<execution>
Expand Down
1 change: 1 addition & 0 deletions microprofile-jwt/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1155,6 +1155,7 @@ The quickstart `pom.xml` file contains a Maven profile named *bootable-jar* whic
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
<add-ons>...</add-ons>
</configuration>
<executions>
Expand Down
1 change: 1 addition & 0 deletions microprofile-jwt/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
</configuration>
<executions>
<execution>
Expand Down
1 change: 1 addition & 0 deletions microprofile-lra/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,7 @@ The quickstart `pom.xml` file contains a Maven profile named *bootable-jar* whic
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
<add-ons>...</add-ons>
</configuration>
<executions>
Expand Down
2 changes: 1 addition & 1 deletion microprofile-lra/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
Rename the output war to ROOT.war before adding it to the server, so that the
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
</configuration>
<executions>
<execution>
Expand Down
1 change: 1 addition & 0 deletions microprofile-openapi/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,7 @@ The quickstart `pom.xml` file contains a Maven profile named *bootable-jar* whic
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
<add-ons>...</add-ons>
</configuration>
<executions>
Expand Down
2 changes: 1 addition & 1 deletion microprofile-openapi/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
Rename the output war to ROOT.war before adding it to the server, so that the
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
</configuration>
<executions>
<execution>
Expand Down
1 change: 1 addition & 0 deletions microprofile-reactive-messaging-kafka/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1587,6 +1587,7 @@ The quickstart `pom.xml` file contains a Maven profile named *bootable-jar* whic
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
<add-ons>...</add-ons>
</configuration>
<executions>
Expand Down
2 changes: 1 addition & 1 deletion microprofile-reactive-messaging-kafka/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@
Rename the output war to ROOT.war before adding it to the server, so that the
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
</configuration>
<executions>
<execution>
Expand Down
1 change: 1 addition & 0 deletions microprofile-rest-client/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ The quickstart `pom.xml` file contains a Maven profile named *bootable-jar* whic
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
<add-ons>...</add-ons>
</configuration>
<executions>
Expand Down
2 changes: 1 addition & 1 deletion microprofile-rest-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@
Rename the output war to ROOT.war before adding it to the server, so that the
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
</configuration>
<executions>
<execution>
Expand Down
1 change: 1 addition & 0 deletions opentelemetry-tracing/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1224,6 +1224,7 @@ The quickstart `pom.xml` file contains a Maven profile named *bootable-jar* whic
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
<add-ons>...</add-ons>
</configuration>
<executions>
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-tracing/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@
</discover-provisioning-info>
<bootable-jar>true</bootable-jar>
<!-- deploys the quickstart on root web context -->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
<packaging-scripts>
<packaging-script>
<scripts>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ The quickstart `pom.xml` file contains a Maven profile named *bootable-jar* whic
application is deployed in the root web context.
-->
<name>ROOT.war</name>
<bootableJarName>${project.artifactId}-bootable.jar</bootableJarName>
<add-ons>...</add-ons>
</configuration>
<executions>
Expand Down
2 changes: 1 addition & 1 deletion shared-doc/run-integration-tests-with-bootable-jar.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ $ mvn clean package -Pbootable-jar
+
[source,subs="attributes+",options="nowrap"]
----
$ mvn wildfly:start-jar
$ mvn wildfly:start-jar -Dbootable-jar-name={artifactId}-bootable.jar
----

. Type the following command to run the `verify` goal with the `integration-testing` profile activated, and specifying the quickstart's URL using the `server.host` system property, which for a bootable jar by default is `{server_provisioning_server_host}`.
Expand Down
Loading