Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-18506] servlet-security quickstart enhancement CY2023Q3 #814

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[WFLY-18506] servlet-security quickstart enhancement CY2023Q3 #814

merged 1 commit into from
Dec 14, 2023

Conversation

istudens
Copy link
Contributor

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 13, 2023

Hi @istudens. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istudens
Copy link
Contributor Author

@emmartins can you review this please? thanks

emmartins
emmartins reviewed Dec 13, 2023
View reviewed changes
servlet-security/pom.xml Outdated Show resolved Hide resolved
emmartins
emmartins requested changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor cosmetic changes, functionally all good.

@istudens
Copy link
Contributor Author

@emmartins done

emmartins
emmartins approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@emmartins emmartins merged commit 817760c into wildfly:main Dec 14, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmartins emmartins emmartins approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@istudens @emmartins