[WFLY-18479][WFLY-18493][WFLY-18523] the starting point for the CY202… #696
Conversation
|
WiP, not for merge |
emmartins
force-pushed
the
post-eap8-qs-enhance
branch
8 times, most recently
from
de40f87
to
a7ca0de
Compare
emmartins
force-pushed
the
post-eap8-qs-enhance
branch
3 times, most recently
from
3f1684e
to
6fdb03e
Compare
emmartins
changed the title
|
The PoC was cleaned and the commit now has the JIRA key tags, IMHO this is now ready to be merged, and thus unlock the work on all other QS. |
|
@zhantemirov @ehsavoie @xstefank fyi I would like to merge this tomorrow, I know that's not much time for a review but by now you guys should be aware of what are the enhancements, and of course later we will have time for optimizations/bugfixes, what matters most now is to provide the base for the enhancement of all QS, as defined by https://issues.redhat.com/browse/WFLY-18411 As an example there were existent arquillian tests on microprofile-config, which I simply disabled here. Further work is needed by Martin, to rework those since managed arquilian is not OpenShift compatible. We can simply keep WFLY-18493 open till a second PR is added there by Martin. |
| <version>${version.plugin.wildfly-jar}</version> | ||
| </plugin> | ||
| </plugins> | ||
| </pluginManagement> |
There was a problem hiding this comment.
to be able to use plugins on CLI (e.g. wildfly:deploy, wildfly-jar:start), up till now this was being inherited from parent but the QS pom.xml should have all the user app needs. In our parent we should only hide what is WFLY devs only (e.g. checkstyle)
| <layers> | ||
| <layer>jaxrs-server</layer> | ||
| <layer>cloud-server</layer> |
There was a problem hiding this comment.
this is intended? Layers should be the same IMO, or I don't understand why it is required.
There was a problem hiding this comment.
The openshift profile now uses standard server provisioning for all, not bootable-jar for MP apps, and I was told the cloud-server layer is what should be used.
| final HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString()); | ||
| assertEquals(200, response.statusCode()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Consider refactoring this class into a separate module that can be shared between all QSs.
There was a problem hiding this comment.
This is pretty much the thing I have thought but in the end could not commit myself too go for it... I know this will add a bit of weird maintenance, after all we are talking about 49 quickstarts, but:
- each quickstart should be a fully independent project, we should include in its module all the user app needs
- it's really just one class, it would be weird to go for an SPI only containing it
- I can't imagine we changing it much
Honestly I think I would prefer to merge the abstract logic on the tests classes, than creating a test SPI (which is more of an internal testing decision)
…3Q3 QS enhancements, for now targeting only helloworld and microprofile-config The following enhancements are included: * maven project version properties rework * maven project plugin management * server provisioning for non MP QS * unified openshift build for all QS, including MP ones, using the standard server provisioning (no bootable jar) * common functionality to provide basic runtime testing for all QS, including MP ones (integration-testing maven profile, Abstract + BasicRuntimeIT, github actions CI) * project CI as specified by WFLY-18523 * reworked asciidoc sections wrt build, run and test for bare metal, server provisioning/bootable-jar, openshift
emmartins
force-pushed
the
post-eap8-qs-enhance
branch
from
6fdb03e
to
36f822d
Compare
…3Q3 QS enhancements, for now targeting only helloworld and microprofile-config
Issues: https://issues.redhat.com/browse/WFLY-18479, https://issues.redhat.com/browse/WFLY-18493, https://issues.redhat.com/browse/WFLY-18523
The following enhancements are included: