Add manifest-from command #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xstefank
commented
Jun 7, 2024
src/main/java/org/wildfly/prospero/extras/channel/merge/ChannelMergeCommand.java
Outdated
Show resolved
Hide resolved
spyrkob
reviewed
Jun 7, 2024
|
|
||
| public static ChannelManifest manifestFrom(List<Channel> channelPaths) { | ||
| return channelPaths.stream() | ||
| .map(channel -> ChannelManifestMapper.from(channel.getManifestCoordinate().getUrl())) |
There was a problem hiding this comment.
@xstefank that will only work if the channel uses URL based manifest. Is that intended or should this work with GA(V) manifests as well?
There was a problem hiding this comment.
no, I forgot about this. I added the functionality, but I can't find an easy quick way to test it. Should it be tested?
There was a problem hiding this comment.
I need to add more testing for this project as we use it more, but for now I think we're good
xstefank
force-pushed
the
manifest-from-channel
branch
from
c8182db
to
c2e1757
Compare
spyrkob
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21