Wildfly mini serie client service #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bstansberry can you assign a reviewer? |
jamezp
reviewed
Nov 13, 2024
Comment on lines
47
to
60
| <repository> | ||
| <id>central</id> | ||
| <name>Main Apache Maven Repository</name> | ||
| <url>https://repo.maven.apache.org/maven2/</url> | ||
| <layout>default</layout> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| </releases> | ||
| <snapshots> | ||
| <enabled>false</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| </snapshots> | ||
| </repository> |
Comment on lines
75
to
87
| <pluginRepository> | ||
| <id>central</id> | ||
| <name>Main Apache Maven Repository</name> | ||
| <url>https://repo.maven.apache.org/maven2/</url> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| </releases> | ||
| <snapshots> | ||
| <enabled>false</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| </snapshots> | ||
| </pluginRepository> |
|
|
||
| <packaging>war</packaging> | ||
| <name>simple-microservice-client-secured</name> | ||
| <description>Insert description for your project here.</description> |
There was a problem hiding this comment.
Seems like we should just delete the description.
|
|
||
| <!-- JBoss dependency versions --> | ||
| <version.wildfly.maven.plugin>5.0.0.Final</version.wildfly.maven.plugin> | ||
| <version.wildfly.bom>33.0.2.Final</version.wildfly.bom> |
| <version.wildfly.bom>33.0.2.Final</version.wildfly.bom> | ||
|
|
||
| <!--Use JUnit 5 here - the WildFly bom still brings 4.x --> | ||
| <version.junit5>5.10.1</version.junit5> |
|
|
||
| <dependency> | ||
| <groupId>org.wildfly.bom</groupId> | ||
| <artifactId>wildfly-microprofile</artifactId> |
There was a problem hiding this comment.
This should be wildfly-expansion for version 34.0.0.Final+
There was a problem hiding this comment.
Thank you @jamezp ... I missed that
| @RegisterClientHeaders | ||
| @RegisterRestClient(configKey="simple-microservice-server") | ||
| @Path("/hello") | ||
| public interface GettingStartedEndpointInterface { |
There was a problem hiding this comment.
IMO we should just name this GettingStartedEndpointClient.
|
@jamezp Thank you for your review! |
|
@jamezp Thank you again for your review, I hope I have fixed everything you pointed out |
tommaso-borgato
force-pushed
the
wildfly-mini-serie-client-service
branch
4 times, most recently
from
04d56fb
to
1999754
Compare
tommaso-borgato
force-pushed
the
wildfly-mini-serie-client-service
branch
from
1999754
to
d9fb804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source code for guides in wildfly/wildfly.org#671