Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T360753: Update preview layout #129

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

medied
Copy link
Contributor

@medied medied commented Jun 25, 2024

https://phabricator.wikimedia.org/T360753

Update to accommodate for new design layout: wikimedia/wikipedia-preview#218. This comes from a sync with Sudhanshu, we are bringing back the gallery and we're leaving the scroll cue

image

@stephanebisson
Copy link
Contributor

I see a few strange things with this PR.

  1. I can't scroll the preview content
  2. I don't see the scroll cue
  3. The "read on wikipedia" link after the content is not styled correctly (see screenshot below)
Screenshot 2024-06-25 at 1 56 47 PM

@medied
Copy link
Contributor Author

medied commented Jun 25, 2024

@stephanebisson I'm not able to replicate those from my end, but I have seen such strange things before like the "read on wikipedia" missing styling and the scrolling issue. Can you confirm you still see those after npm link again with the main branch from core and trying it out on different posts and previews? Usually takes a dance of rebuilding on both the core and the plugin, might need to run the postinstall script manually on plugin side

@stephanebisson
Copy link
Contributor

I redid the npm link dance and it works now.

@stephanebisson stephanebisson merged commit 429e1e5 into main Jun 25, 2024
1 check passed
@stephanebisson stephanebisson deleted the T360753-gallery-row-update branch June 25, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants