Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T360286: Sections style updates #127

Merged
merged 5 commits into from
Jun 25, 2024
Merged

T360286: Sections style updates #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9d66d6b
Fix footer and add min-height to preview
medied Jun 13, 2024
581501b
Fix header title text overflow
medied Jun 13, 2024
9a8363f
Update header styling
medied Jun 13, 2024
c21e4e3
Update list item style
medied Jun 13, 2024
8da7470
Only one close icon for views
medied Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/link/images/close-language.svg
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions src/link/images/close-view.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion src/link/sections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ export const Sections = ( {
return (
<div className={ `${ sectionsPrefix }` }>
<div className={ `${ sectionsPrefix }-header` }>
{ titleWithoutSection( activeAttributes.title ) }
<div className={ `${ sectionsPrefix }-header-title` }>
{ titleWithoutSection( activeAttributes.title ) }
</div>
<div
className={ `${ sectionsPrefix }-header-close` }
onClick={ () => setSelectingSection( false ) }
Expand Down
55 changes: 41 additions & 14 deletions src/link/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ body {
line-height: 19.55px;

&-close {
background-image: url(./images/close-language.svg);
background-image: url(./images/close-view.svg);
width: 20px;
height: 20px;
cursor: pointer;
Expand Down Expand Up @@ -351,6 +351,7 @@ body {

.wikipediapreview-edit-preview {
width: 350px;
min-height: 214px;

&-container {
display: flex;
Expand Down Expand Up @@ -423,20 +424,36 @@ body {
}

.wikipediapreview-footer {
position: relative;
display: flex;
align-items: center;
justify-content: center;
height: 40px;
z-index: 5;

&-cta-readmore {
display: none;
}
&-link {
margin-right: 5px;

&-cta {
text-decoration: none;
font-size: 14px;
color: #36c;
margin-right: 4px;

&-cta-readonwiki {
display: block;
&:hover {
text-decoration: underline;
}

&:visited {
color: #6B4BA1;
svg path {
fill: #6B4BA1;
}
}
}
}
}
}

.wikipediapreview-body::after {
content: none;
}
}

&.is-expanded {
Expand Down Expand Up @@ -547,14 +564,24 @@ body {
min-height: 70px;
display: flex;
align-items: center;
padding: 0 10px 0 10px;
padding: 0 16px 0 16px;
font-size: 16px;
font-weight: bold;
border-bottom: 1px solid #c8ccd1;
justify-content: space-between;

&-title {
max-width: 90%;
text-overflow: ellipsis;
display: -webkit-box;
-webkit-line-clamp: 2;
-webkit-box-orient: vertical;
overflow: hidden;
color: #202122
}

&-close {
background-image: url(./images/close-language.svg);
background-image: url(./images/close-view.svg);
width: 20px;
height: 20px;
cursor: pointer;
Expand All @@ -568,8 +595,8 @@ body {
&-item {
display: flex;
align-items: center;
padding: 5px;
margin: 5px;
padding: 4px;
margin: 8px;

&-content {
display: flex;
Expand Down